pymc
pymc copied to clipboard
Adding meta-information for MeasurableOps
Description
This PR aims to solve issue https://github.com/pymc-devs/pymc/issues/6360 and is a cotinuation of the PR https://github.com/pymc-devs/pymc/pull/6685 and PR https://github.com/pymc-devs/pymc/pull/6754 by incorporating RV meta information in intermediate MeasurableVariables. The Measurable ops covered are MeasurableComparison, MeasurableClip, MeasurableRound, MeasurableSpecifyShape, MeasurableCheckAndRaise, MeasurableIfElse, MeasurableScan, MeasurableMakeVector, MeasurableJoin, MeasurableDimShuffle, MeasurableTransforms and DiracDelta.
cc: @ricardoV94 @larryshamalama
Related Issue
- [ ] Closes # https://github.com/pymc-devs/pymc/issues/6360
- [ ] Related to # https://github.com/pymc-devs/pymc/pull/6754
Checklist
- [x] Checked that the pre-commit linting/style checks pass
- [x] Included tests that prove the fix is effective or that the new feature works
- [x] Added necessary documentation (docstrings and/or example notebooks)
- [ ] If you are a pro: each commit corresponds to a relevant logical change
Type of change
- [x] New feature / enhancement
- [ ] Bug fix
- [ ] Documentation
- [ ] Maintenance
- [ ] Other (please specify):
📚 Documentation preview 📚: https://pymc--7076.org.readthedocs.build/en/7076/
Codecov Report
Attention: Patch coverage is 30.90909%
with 114 lines
in your changes are missing coverage. Please review.
Project coverage is 63.23%. Comparing base (
4f6831e
) to head (7157900
). Report is 1 commits behind head on main.
:exclamation: Current head 7157900 differs from pull request most recent head ddcda2f. Consider uploading reports for the commit ddcda2f to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #7076 +/- ##
===========================================
- Coverage 92.30% 63.23% -29.08%
===========================================
Files 100 100
Lines 16895 16990 +95
===========================================
- Hits 15595 10743 -4852
- Misses 1300 6247 +4947
Files | Coverage Δ | |
---|---|---|
pymc/logprob/transforms.py | 55.38% <0.00%> (-40.08%) |
:arrow_down: |
pymc/logprob/cumsum.py | 38.23% <50.00%> (-52.95%) |
:arrow_down: |
pymc/logprob/censoring.py | 61.22% <62.50%> (-34.48%) |
:arrow_down: |
pymc/logprob/binary.py | 28.88% <0.00%> (-65.43%) |
:arrow_down: |
pymc/logprob/checks.py | 38.88% <42.85%> (-51.86%) |
:arrow_down: |
pymc/logprob/abstract.py | 80.26% <70.58%> (-15.20%) |
:arrow_down: |
pymc/logprob/scan.py | 16.82% <13.33%> (-80.71%) |
:arrow_down: |
pymc/logprob/tensor.py | 25.78% <23.52%> (-51.08%) |
:arrow_down: |
pymc/logprob/order.py | 27.61% <23.52%> (-66.99%) |
:arrow_down: |
pymc/logprob/mixture.py | 19.84% <7.31%> (-76.23%) |
:arrow_down: |
@Dhruvanshu-Joshi do you have a chance to update the PR to fix the conflicts? Otherwise was anything missing?
No there was not any feature missing to be added. I'll solve the conflicts and push the updates asap.