pymc
pymc copied to clipboard
Update HSGP prior_linearized example to point to _m_star instead of m_star
What is this PR about?
The docs for pymc.gp.HSGP.prior_linearized refer to m_star to find the number of basis functions used in the approximation, but that value is actually stored as _m_star.
Major / Breaking Changes
- N/A
New features
- N/A
Bugfixes
- N/A
Documentation
- Two small fixes to the
prior_linearizeddocstring in pymc/gp/hsgp_approx.py
Maintenance
- N/A
:books: Documentation preview :books:: https://pymc--6731.org.readthedocs.build/en/6731/
:sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.
Codecov Report
Merging #6731 (6cf3038) into main (cafb60b) will decrease coverage by
16.64%. The diff coverage isn/a.
Additional details and impacted files
@@ Coverage Diff @@
## main #6731 +/- ##
===========================================
- Coverage 92.00% 75.36% -16.64%
===========================================
Files 95 95
Lines 16190 16190
===========================================
- Hits 14896 12202 -2694
- Misses 1294 3988 +2694
| Impacted Files | Coverage Δ | |
|---|---|---|
| pymc/gp/hsgp_approx.py | 24.03% <ø> (-68.27%) |
:arrow_down: |
Hey @kforeman, if you merge the latest master the tests should pass then
@bwengals @danhphan do one of you wants to revive the PR (or anyone else)
Sorry about that, I was on vacation and then swamped at work so didn't have time to go back and update this - I will tackle it this weekend! Thanks for the poke
I'm pretty sure that the failing tests are unrelated to your change. A rebase on latest main should fix them.
On another note: It would be better to introduce an m_star property instead of telling users to access private attributes
Hi @kforeman I hope everything’s going great! Do you think you might have time to wrap up this PR?