pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Update HSGP prior_linearized example to point to _m_star instead of m_star

Open kforeman opened this issue 2 years ago • 7 comments

What is this PR about? The docs for pymc.gp.HSGP.prior_linearized refer to m_star to find the number of basis functions used in the approximation, but that value is actually stored as _m_star.

Major / Breaking Changes

  • N/A

New features

  • N/A

Bugfixes

  • N/A

Documentation

Maintenance

  • N/A

:books: Documentation preview :books:: https://pymc--6731.org.readthedocs.build/en/6731/

kforeman avatar May 23 '23 23:05 kforeman

Thank You Banner :sparkling_heart: Thanks for opening this pull request! :sparkling_heart: The PyMC community really appreciates your time and effort to contribute to the project. Please make sure you have read our Contributing Guidelines and filled in our pull request template to the best of your ability.

welcome[bot] avatar May 23 '23 23:05 welcome[bot]

Codecov Report

Merging #6731 (6cf3038) into main (cafb60b) will decrease coverage by 16.64%. The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #6731       +/-   ##
===========================================
- Coverage   92.00%   75.36%   -16.64%     
===========================================
  Files          95       95               
  Lines       16190    16190               
===========================================
- Hits        14896    12202     -2694     
- Misses       1294     3988     +2694     
Impacted Files Coverage Δ
pymc/gp/hsgp_approx.py 24.03% <ø> (-68.27%) :arrow_down:

... and 40 files with indirect coverage changes

codecov[bot] avatar Jun 21 '23 01:06 codecov[bot]

Hey @kforeman, if you merge the latest master the tests should pass then

bwengals avatar Jul 07 '23 23:07 bwengals

@bwengals @danhphan do one of you wants to revive the PR (or anyone else)

ricardoV94 avatar Aug 24 '23 11:08 ricardoV94

Sorry about that, I was on vacation and then swamped at work so didn't have time to go back and update this - I will tackle it this weekend! Thanks for the poke

kforeman avatar Aug 24 '23 16:08 kforeman

I'm pretty sure that the failing tests are unrelated to your change. A rebase on latest main should fix them.

On another note: It would be better to introduce an m_star property instead of telling users to access private attributes

michaelosthege avatar Sep 01 '23 14:09 michaelosthege

Hi @kforeman I hope everything’s going great! Do you think you might have time to wrap up this PR?

aloctavodia avatar Jul 16 '24 12:07 aloctavodia