pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Bump Aesara and Aeppl dependencies

Open ricardoV94 opened this issue 2 years ago • 5 comments

ricardoV94 avatar Sep 20 '22 11:09 ricardoV94

Codecov Report

Merging #6140 (a044194) into main (4c92adf) will increase coverage by 1.30%. The diff coverage is 91.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6140      +/-   ##
==========================================
+ Coverage   91.28%   92.58%   +1.30%     
==========================================
  Files         101      101              
  Lines       20945    20945              
==========================================
+ Hits        19119    19392     +273     
+ Misses       1826     1553     -273     
Impacted Files Coverage Δ
pymc/aesaraf.py 93.38% <ø> (ø)
pymc/model.py 88.23% <ø> (ø)
pymc/smc/smc.py 74.80% <0.00%> (-22.45%) :arrow_down:
pymc/distributions/continuous.py 97.50% <100.00%> (ø)
pymc/distributions/multivariate.py 92.31% <100.00%> (ø)
pymc/variational/updates.py 92.11% <100.00%> (ø)
pymc/smc/sample_smc.py 77.85% <0.00%> (-5.37%) :arrow_down:
pymc/backends/base.py 86.44% <0.00%> (+0.73%) :arrow_up:
pymc/step_methods/slicer.py 96.20% <0.00%> (+1.26%) :arrow_up:
... and 4 more

codecov[bot] avatar Sep 20 '22 11:09 codecov[bot]

Test failures :(.

twiecki avatar Sep 20 '22 11:09 twiecki

Test failures :(.

Not super shocked, this one changed quite some fundamentals

ricardoV94 avatar Sep 20 '22 12:09 ricardoV94

Bug should be fixed in https://github.com/aesara-devs/aesara/pull/1199

Other bug still unclear: https://github.com/aesara-devs/aesara/issues/1200

ricardoV94 avatar Sep 20 '22 14:09 ricardoV94

@Armavica I reverted a commit of yours as it had invalid logic, feel free to open a new PR and I can leave specific feedback there.

ricardoV94 avatar Sep 20 '22 15:09 ricardoV94