pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Refactor `sample_posterior_predictive_w` for V4

Open zaxtax opened this issue 2 years ago • 3 comments

This tries to address #4807

Right now, it passes all unit tests, but doesn't use the fast sampling procedure of sample_posterior_predictive

The code is also not feature-complete.

zaxtax avatar May 24 '22 13:05 zaxtax

fast posterior_predictive_sampling no longer exists (everything is fast now). Also some tweaks will be needed following #5787 which should be merged soon!

ricardoV94 avatar May 24 '22 13:05 ricardoV94

Codecov Report

Merging #5800 (6683916) into main (1e7d91f) will increase coverage by 0.43%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5800      +/-   ##
==========================================
+ Coverage   88.99%   89.43%   +0.43%     
==========================================
  Files          74       74              
  Lines       13809    13807       -2     
==========================================
+ Hits        12290    12348      +58     
+ Misses       1519     1459      -60     
Impacted Files Coverage Δ
pymc/sampling.py 89.68% <100.00%> (+7.16%) :arrow_up:
pymc/parallel_sampling.py 86.46% <0.00%> (-1.00%) :arrow_down:
pymc/backends/base.py 86.44% <0.00%> (-0.74%) :arrow_down:

codecov[bot] avatar May 24 '22 13:05 codecov[bot]

Let me make those tweaks and push tonight.

zaxtax avatar May 26 '22 10:05 zaxtax

Closing in favour of #6254

zaxtax avatar Oct 29 '22 22:10 zaxtax