pymc
pymc copied to clipboard
Refactor `sample_posterior_predictive_w` for V4
This tries to address #4807
Right now, it passes all unit tests, but doesn't use the fast sampling procedure of sample_posterior_predictive
The code is also not feature-complete.
fast posterior_predictive_sampling no longer exists (everything is fast now). Also some tweaks will be needed following #5787 which should be merged soon!
Codecov Report
Merging #5800 (6683916) into main (1e7d91f) will increase coverage by
0.43%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #5800 +/- ##
==========================================
+ Coverage 88.99% 89.43% +0.43%
==========================================
Files 74 74
Lines 13809 13807 -2
==========================================
+ Hits 12290 12348 +58
+ Misses 1519 1459 -60
Impacted Files | Coverage Δ | |
---|---|---|
pymc/sampling.py | 89.68% <100.00%> (+7.16%) |
:arrow_up: |
pymc/parallel_sampling.py | 86.46% <0.00%> (-1.00%) |
:arrow_down: |
pymc/backends/base.py | 86.44% <0.00%> (-0.74%) |
:arrow_down: |
Let me make those tweaks and push tonight.
Closing in favour of #6254