pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Update docstrings for better rendering on website and numpydoc compliance

Open OriolAbril opened this issue 3 years ago • 25 comments

Overview

We have to review and update all the docstrings of objects part of the public API (that is, that appear on the API reference section of the website). Why?

There are two main reasons:

  • Some functions are not documented correctly. i.e. pymc.Uniform didn't document that lower and upper bounds are optional and default to 0 and 1 respectively
  • Not following numpydoc results in non-ideal rendering. i.e. if there are no spaces around the colon that separates parameter name and type numpydoc+sphinx can't render it correctly and the type ends up being shown as bold text instead of being a link to the documentation of that object (which is particularly useful for functions taking or returning external objects such as ArviZ InferenceData or aesara TensorVariable).

Current view of the parameter section of pymc.Uniform

imatge

Before doing the changes described below

imatge

Details

A detailed tutorial on how to go about these updates is available at the PyMC-Data Umbrella sprint website (the page also has a video recorded by @reshamas showing an example PR).

How to choose what page to work on?

Look for pages that don't have hyperlinks in all their parameters. In case of doubt, don't hesitate to ask in this issue for pages to work on.

OriolAbril avatar Feb 10 '22 20:02 OriolAbril

I am working on the docstrings for weibull distribution.

EDIT (by @OriolAbril ): I moved the updated list to the initial comment so its easier to find for new people getting to this issue

ravichikkam avatar Feb 15 '22 23:02 ravichikkam

Working on pm.Data.

jmloyola avatar Feb 18 '22 17:02 jmloyola

Is this where the ConstantData and MutableData docs should appear? https://docs.pymc.io/en/v3/api/data.html. I can't find them.

Edit: There in v4 here https://docs.pymc.io/en/latest/api/data.html

cuchoi avatar Feb 18 '22 19:02 cuchoi

Working on pymc.Exponential

chritter avatar Feb 18 '22 19:02 chritter

Going to work on pymc.HyperGeometric

cuchoi avatar Feb 18 '22 19:02 cuchoi

Working on pymc.Normal

sagartomar avatar Feb 18 '22 19:02 sagartomar

Working on pymc.Flat

lalitmusmade avatar Feb 18 '22 20:02 lalitmusmade

Working on pymc.GaussianRandomWalk

GallowayJ avatar Feb 18 '22 20:02 GallowayJ

I'll start on pymc.Gamma

areding avatar Feb 19 '22 10:02 areding

Starting pymc.InverseGamma.

areding avatar Feb 19 '22 11:02 areding

Starting with pymc.Beta

sagartomar avatar Feb 19 '22 11:02 sagartomar

Working on pymc.HalfFlat

lalitmusmade avatar Feb 19 '22 12:02 lalitmusmade

@jlindbloom and I are working on Other utils

bdatko avatar Jul 09 '22 14:07 bdatko

I am working on the class docstrings inside the multivariate module.

pibieta avatar Jul 16 '22 15:07 pibieta

Me and @pibieta are working on the rest of the classes docstrings inside the multivariate module. #DataUmbrellaPyMCSprint Cc: @reshamas

vitaliset avatar Jul 22 '22 17:07 vitaliset

working on docstring for pm.simulator

daniel-saunders-phil avatar Aug 06 '22 01:08 daniel-saunders-phil

I can take smc

rowan-schaefer avatar Aug 19 '22 01:08 rowan-schaefer

I can take smc

maybe we could work together on it! I've been working with a little bit this week and have a number of ideas. Do you know a good technique to co-write a PR?

daniel-saunders-phil avatar Aug 19 '22 01:08 daniel-saunders-phil

I'll message you!

rowan-schaefer avatar Aug 19 '22 02:08 rowan-schaefer

I'll take pm.AR

daniel-saunders-phil avatar Aug 29 '22 17:08 daniel-saunders-phil

Currently working on pymc.variational.inference!

rowan-schaefer avatar Oct 13 '22 15:10 rowan-schaefer

I will work on pymc.DiscreteWeibull

hyosubkim avatar Nov 09 '22 20:11 hyosubkim

I'm getting pymc.model.core.Model

apalermo01 avatar Jan 09 '24 01:01 apalermo01

I will work on pymc.step_methods.BinaryGibbsMetropolis at this link: https://www.pymc.io/projects/docs/en/stable/api/generated/pymc.step_methods.BinaryGibbsMetropolis.html

HangenYuu avatar Mar 22 '24 00:03 HangenYuu