pymc icon indicating copy to clipboard operation
pymc copied to clipboard

Published 20 hours ago • verified publisher icon pymc-devs

Refactor `sample_posterior_predictive_w` for V4

Open ricardoV94 opened this issue 3 years ago • 8 comments

ricardoV94 avatar Jun 27 '21 06:06 ricardoV94

Maybe we should deprecate this one instead?

ricardoV94 avatar Sep 28 '21 18:09 ricardoV94

And move the functionality to sample_posterior_predictive?

aloctavodia avatar Sep 29 '21 04:09 aloctavodia

And move the functionality to sample_posterior_predictive?

I was discussing deprecating it altogether (not saying we should, just asking).

ricardoV94 avatar Sep 29 '21 07:09 ricardoV94

I think we should keep the functionality either in this function or in sample_posterior_predictive

aloctavodia avatar Sep 29 '21 08:09 aloctavodia

@aloctavodia would you be interested/available to refactor this one? Nobody volunteered in a long time now :)

ricardoV94 avatar May 23 '22 15:05 ricardoV94

@zaxtax I think expressed interest.

twiecki avatar May 23 '22 22:05 twiecki

I have something that works and passes unit tests, but is not efficient. Maybe I can open a WIP for it.

zaxtax avatar May 24 '22 06:05 zaxtax

I have something that works and passes unit tests, but is not efficient. Maybe I can open a WIP for it.

Definitely!

ricardoV94 avatar May 24 '22 08:05 ricardoV94

I suggest removing this feature due to low interest from the community

ricardoV94 avatar Oct 27 '22 13:10 ricardoV94

@ricardoV94 I agree. I think this should be deprecated in favour of https://github.com/arviz-devs/arviz/pull/2147 when it is merged.

zaxtax avatar Oct 29 '22 22:10 zaxtax