pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Update example notebook for mediation analysis to correct package name to PyMC #574

Open asarjou opened this issue 1 year ago • 3 comments

#574

Updating the mediation_analysis notebook to update the markdown to correct the package name.

When rerunning the notebook, seaborn raised some Future warnings which were suppressed using the warnings package

  • [x] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
  • [x] PR description contains a link to the relevant issue:
    • a tracker one for existing notebooks (tracker issues have the "tracker id" label)
    • or a proposal one for new notebooks
  • [x] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

Helpful links

  • https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md

:books: Documentation preview :books:: https://pymc-examples--576.org.readthedocs.build/en/576/

asarjou avatar Sep 16 '23 15:09 asarjou

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

I'm not sure if there's a specific policy about suppression of warnings. If it's easy to update the arviz calls to avoid those (and need for warning suppression) then that would be ideal. Any thoughts @OriolAbril?

Warnings should be fixed instead of ignored. Only if there are some issues with trying to fix it (e.g. needing a dependency to be updated or a release to happen) they should be ignored.

@asarjou if you share the complete warning you got from seaborn we might be able to help with its fix.

OriolAbril avatar Sep 28 '23 12:09 OriolAbril

Saw some seaborn warnings in a different PR. Using the latest release candidate should fix them if they are the same: https://github.com/mwaskom/seaborn/releases/tag/v0.13.0rc0

OriolAbril avatar Sep 28 '23 12:09 OriolAbril

the pymc3->pymc change has already been fixed, I'll close the PR and issue.

OriolAbril avatar Aug 01 '24 20:08 OriolAbril