pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Added example for using ModelBuilder for pymc_experimental

Open 5hv5hvnk opened this issue 2 years ago • 6 comments

merged code

5hv5hvnk avatar Sep 13 '22 15:09 5hv5hvnk

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Still many syntax errors.

twiecki avatar Sep 17 '22 08:09 twiecki

Yes, I am having some trouble fixing them because jupyter-lab was not working, I have fixed it and now working on syntactical errors and other failed build tests.

5hv5hvnk avatar Sep 17 '22 11:09 5hv5hvnk

image

This file is still showing up. Maybe you can jsut manually remove it. Also pre-commit seems borked again, did you run it locally?

twiecki avatar Sep 20 '22 18:09 twiecki

Just a thought... seeing as this is still in pymc-experimental and the API may change (e.g. https://github.com/pymc-devs/pymcx/issues/88), do we want to solidify this with an example notebook at this point?

drbenvincent avatar Oct 11 '22 07:10 drbenvincent

@drbenvincent I think I should complete the desired changes with the ModelBuilder and change the example notebook accordingly.

5hv5hvnk avatar Oct 12 '22 07:10 5hv5hvnk

I am not following pymc-experimental, is this still waiting to be updated to changes there? ready to merge?

OriolAbril avatar Nov 05 '22 20:11 OriolAbril

Hello there, sp I had to update the package in pymcx which is complete. But by then there was a bug in arviz that was fixed by the arviz team that extends this code with a new feature (which I haven't) completed yet so I will get on this and make sure to commit new updates by end of this week.

5hv5hvnk avatar Nov 11 '22 13:11 5hv5hvnk

@OriolAbril I rewrote large chunks and addressed your comments. Can you check again?

twiecki avatar Feb 16 '23 09:02 twiecki

Ping @OriolAbril.

twiecki avatar Feb 21 '23 15:02 twiecki

@OriolAbril Done!

twiecki avatar Feb 22 '23 11:02 twiecki

Thanks @OriolAbril. What needs to happen for this to be on the website?

twiecki avatar Feb 22 '23 14:02 twiecki

It is there already, in the how to section. Link to notebook: https://www.pymc.io/projects/examples/en/latest/howto/model_builder.html

OriolAbril avatar Feb 22 '23 14:02 OriolAbril