pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Bayesian A/B Testing Introduction - Apply best practices

Open tcuongd opened this issue 2 years ago • 3 comments

  • Update notebook to follow style guide, addresses https://github.com/pymc-devs/pymc-examples/issues/172
  • Rename notebook to bayesian_ab_testing_introduction.ipynb, to make its purpose clear compared to future notebooks about Bayesian A/B testing.

tcuongd avatar Jun 26 '22 11:06 tcuongd

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

There is a math related rendering issue in https://pymcio--383.org.readthedocs.build/projects/examples/en/383/case_studies/bayesian_ab_testing_introduction.html#value-conversions after the first code blocks.

OriolAbril avatar Jul 11 '22 11:07 OriolAbril

Thanks for the PR and sorry for ths slowness in reviewing

OriolAbril avatar Jul 11 '22 12:07 OriolAbril

Hmm this is the error when building the docs on CI:

  File "/home/docs/checkouts/readthedocs.org/user_builds/pymc-examples/envs/383/lib/python3.8/site-packages/myst_nb/core/render.py", line 626, in render_image
    data_bytes = a2b_base64(data.content)
binascii.Error: Incorrect padding

Have you seen this before?

tcuongd avatar Sep 10 '22 10:09 tcuongd

Sorry, the PR slipped through the cracks. I haven't seen that before. Can you try rebasing and see if the same error persists?

OriolAbril avatar Sep 19 '22 23:09 OriolAbril