pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Update mean cov GP notebook

Open canyon289 opened this issue 2 years ago • 6 comments

Update mean and cov notebook

Just update image size so it doesn't require scrolling

  • [ ] Notebook follows style guide https://docs.pymc.io/en/latest/contributing/jupyter_style.html
  • [ ] PR description contains a link to the relevant issue: a tracker one for existing notebooks or a proposal one for new notebooks
  • [x] Check the notebook is not excluded from any pre-commit check: https://github.com/pymc-devs/pymc-examples/blob/main/.pre-commit-config.yaml

Questions and answers

  • I'm pretty sure I followed style guide but am not entirely sure?
  • closes https://github.com/pymc-devs/pymc-examples/issues/300. Also related to #75
  • Did I remove notebook from precommit check correctly?

Helpful links

  • https://github.com/pymc-devs/pymc-examples/blob/main/CONTRIBUTING.md

canyon289 avatar Mar 24 '22 02:03 canyon289

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Where do I put diataxis type? image

canyon289 avatar Mar 24 '22 02:03 canyon289

View / edit / reply to this conversation on ReviewNB

OriolAbril commented on 2022-03-31T21:30:26Z ----------------------------------------------------------------

The myst target (the text inside the()= ) should be something that is specific to this notebook, for example (and preferably to avoid confusions) the file name of the notebook


Where do I put diataxis type?

There can be multiple categories like there are multiple tags: :category: intermediate, reference

OriolAbril avatar Mar 31 '22 21:03 OriolAbril

View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2022-04-01T05:52:23Z ----------------------------------------------------------------

Line #10.    %matplotlib inline

Do we need this?


View / edit / reply to this conversation on ReviewNB

aloctavodia commented on 2022-04-01T05:52:24Z ----------------------------------------------------------------

Instead of FIGSIZE = (10, 4)

you can do

plt.rcParams["figure.figsize"] = (10,4)

and then all figures in the session will have the desired figsize, without needing to manually pass FIGSIZE