pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

Typo in GLM hierarchical binomial model

Open farhanreynaldo opened this issue 2 years ago • 2 comments

Notebook title: GLM hierarchical binomial model Notebook url: https://github.com/pymc-devs/pymc-examples/blob/main/examples/generalized_linear_models/GLM-hierarchical-binominal-model.ipynb

Issue description

I found several minor errors in the notebook, listed as follows:

  • In the notebook title and its filename, is the word binominal instead of binomial chosen by intention?
  • I found several typos in hierarchical in various spelling, namely heirarchical and heirarchichal.
  • There is inconsistency in PyMC3 spelling, which is pymc3.

And I would suggest suppressing the matplotlib code line (e.g. <AxesSubplot:xlabel='X', ylabel='Z'>) on figure output by putting the semicolon in the last line of code.

I would be happy to open a PR if any of the errors mentioned above are valid.

farhanreynaldo avatar Nov 10 '21 07:11 farhanreynaldo

sounds great, can you also make sure it follows the style guide?

OriolAbril avatar Nov 10 '21 15:11 OriolAbril

sounds great, can you also make sure it follows the style guide?

Sure, I will make the PR.

farhanreynaldo avatar Nov 11 '21 03:11 farhanreynaldo