pymc-examples icon indicating copy to clipboard operation
pymc-examples copied to clipboard

dirichlet process mixtures for density estimation

Open OriolAbril opened this issue 3 years ago • 4 comments

File: https://github.com/pymc-devs/pymc-examples/blob/main/examples/mixture_models/dp_mix.ipynb Reviewers:

The sections below may still be pending. If so, the issue is still available, it simply doesn't have specific guidance yet. Please refer to this overview of updates

Known changes needed

Changes listed in this section should all be done at some point in order to get this notebook to a "Best Practices" state. However, these are probably not enough! Make sure to thoroughly review the notebook and search for other updates.

General updates

ArviZ related

Changes for discussion

Changes listed in this section are up for discussion, these are ideas on how to improve the notebook but may not have a clear implementation, or fix some know issue only partially.

General updates

ArviZ related

Notes

Exotic dependencies

Computing requirements

OriolAbril avatar Apr 05 '21 00:04 OriolAbril

I tried moving from nbsphinx to myst-nb and was unable to do so because the widgets in this notebook are not saved correctly, see https://github.com/jupyter/jupyter-sphinx/blob/master/jupyter_sphinx/ast.py#L607. After manually editing the metadata to remove the widgets completely I was able to build the documentation.

Side note: the DE-MCMC notebooks also have widgets but they are correctly saved are are not a problem.

OriolAbril avatar Jun 08 '21 09:06 OriolAbril

can I work on this, since the previous PR only made metadata changes?

chiral-carbon avatar Aug 14 '21 10:08 chiral-carbon

Yes, it still needs to be updated. I only fixed the metadata because it was broken and was blocking the switch from nbsphinx to myst-nb

OriolAbril avatar Aug 16 '21 07:08 OriolAbril

Hi, I would like to update this notebook to pymc v4, is there anything I should know?

LegrandNico avatar Sep 15 '22 10:09 LegrandNico