sqlalchemy-media icon indicating copy to clipboard operation
sqlalchemy-media copied to clipboard

version 1.17.4 (latest) has incorrect documentation regarding cropping of images

Open MoralCode opened this issue 3 years ago • 1 comments

  • processors.py:337-ish as of commit 6ab9496a230d9d64b1aa80deafd229dea24d2624 says that, for the ImageProcessor class "The crop argument is 4-tuple of (left, top, right, bottom)" this matches with what the pillow library documentation wants (the lib that actually does the cropping).
  • The README demonstrates that this should be a dict of the form {left='10%',top='10%',width='80%', height='80%'}.
  • no code seems to exist to convert between these forms or even validate the inputs of this dict

whats the intended functionality? which piece of documentation is incorrect since they're both in conflict?

MoralCode avatar Dec 11 '22 19:12 MoralCode

the unit tests seem to use this tuple format, leading me to believe the README is just incorrect

MoralCode avatar Dec 11 '22 20:12 MoralCode