user.js
user.js copied to clipboard
pyllyukko
Consider enabling WebRTC in the future
Firefox 52 is the new ESR - in which the LAN IP address leak is fixed. So we should either:
- comment out the pref disabling WebRTC (
media.peerconnection.enabled) - leave it as is for hardening purposes, and close this issue
- if notable functionality breakage is found due to WebRTC being disabled, add a
NOTICE:field alongside that pref.
media.peerconnection.ice.default_address_only should also be removed since the way to disable the leaking of internal IP addresses is media.peerconnection.ice.no_host in Firefox >= 52.
@fmarier media.peerconnection.ice.no_host is already present (https://github.com/pyllyukko/user.js/blob/master/user.js#L61)
media.peerconnection.ice.default_address_only is there for legacy reasons (with a clear indicator that this is for firefox < 51).
Or should we remove all prefs for versions older than the current ESR? (whole other issue)
leave it as is for hardening purposes, and close this issue
I would say we keep it disabled for now and revisit this issue a bit later.
if notable functionality breakage is found due to WebRTC being disabled, add a NOTICE: field alongside that pref.
Of course.
@fmarier media.peerconnection.ice.no_host is already present (https://github.com/pyllyukko/user.js/blob/master/user.js#L61)
The comment in user.js says Firefox >= 51 and @fmarier said it's Firefox >= 52...
media.peerconnection.ice.default_address_only is there for legacy reasons (with a clear indicator that this is for firefox < 51).
Yep.
Or should we remove all prefs for versions older than the current ESR? (whole other issue)
No. At least not yet, as ESR 52 is just out of the oven and some distros are still using ESR 45.*.
No. At least not yet, as ESR 52 is just out of the oven and some distros are still using ESR 45.*.
https://github.com/pyllyukko/user.js/issues/251
The comment in user.js says Firefox >= 51 and @fmarier said it's Firefox >= 52...
Yes, this should be clarified. @fmarier is probably right, will edit the comment.
I will amend https://github.com/pyllyukko/user.js/pull/249 to re-disable WebRTC. If there are not other points to discuss I think this issue can be closed (changes like this can be tracked in #251)
WebRTC was re-enabled in 9763829, then re-disabled in https://github.com/pyllyukko/user.js/commit/ac1a8184a9bc83383d290800a6e92948c62e7bbd. This issue should be reopened.
- Disabling WebRTC is not needed in Firefox > 52 (Related #251)
- WebRTC would be worth re-enabling in a "relaxed" variant (Related #231)