Extend consider-using-join to detect non-empty separators

[lggruspe]

Type of Changes

	Type
✓	:sparkles: New feature

Description

consider-using-join now detects more refactoring opportunities.

Example:

result = ''
for number in ['1', '2', '3']:
    result += f"{number}, "

Closes #6639

[coveralls]

Pull Request Test Coverage Report for Build 3455851329

• 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
• 243 unchanged lines in 28 files lost coverage.
• Overall coverage increased (+0.08%) to 95.404%

---

Files with Coverage Reduction	New Missed Lines	%
pylint/checkers/strings.py	1	94.07%
pylint/config/arguments_manager.py	1	97.86%
pylint/extensions/code_style.py	1	99.15%
pylint/lint/parallel.py	1	94.12%
pylint/message/message_definition_store.py	1	98.39%
pylint/reporters/multi_reporter.py	1	98.21%
pylint/utils/pragma_parser.py	1	98.25%
pylint/checkers/modified_iterating_checker.py	2	97.8%
pylint/extensions/docparams.py	2	98.51%
pylint/message/message_definition.py	2	97.37%
<!--	Total:	243

Totals
Change from base Build 3073813801:	0.08%
Covered Lines:	17333
Relevant Lines:	18168

---

💛 - Coveralls

[lggruspe]

Should I add astroid to tests/primer/packages_to_lint_batch_one.json? I'm not sure how to fix the cache error.

[Pierre-Sassoulas]

I'm not sure how to fix the cache error.

I'm not sure either, it could be due to astroid 2.12.10 being released now and the dependencies not being exactly the same. It's going to calm down when we merge the maintenance branch with updated astroid. I relaunched the primer to see if it fix the problem.

[github-actions[bot]]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit f5309a91953983dd35207069607ea574699c22ad

[github-actions[bot]]

🤖 According to the primer, this change has no effect on the checked open source code. 🤖🎉

This comment was generated for commit 28fc9c5f3b6fa928680228171f839d5972ce6483