pylint icon indicating copy to clipboard operation
pylint copied to clipboard

Published 20 hours ago • verified publisher icon pylint-dev

Refactor check()

Open DanielNoord opened this issue 1 year ago • 2 comments

  • [x] Add yourself to CONTRIBUTORS if you are a new contributor.
  • [x] Write a good description on what the PR does.

Type of Changes

Type
✓ :hammer: Refactoring

Description

Refs https://github.com/PyCQA/pylint/issues/7263.

Blocked by #7286.

DanielNoord avatar Aug 10 '22 22:08 DanielNoord

Pull Request Test Coverage Report for Build 2875868156

  • 47 of 47 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 95.252%
Files with Coverage Reduction New Missed Lines %
pylint/lint/pylinter.py 1 95.25%
<!-- Total: 1
Totals Coverage Status
Change from base Build 2872236273: 0.007%
Covered Lines: 16872
Relevant Lines: 17713
💛 - Coveralls

coveralls avatar Aug 10 '22 22:08 coveralls

🤖 Effect of this PR on checked open source code: 🤖

Effect on django: The following messages are no longer emitted:

  1. no-member: Instance of 'str' has no 'get' member https://github.com/django/django/blob/main/django/urls/resolvers.py#L642

Effect on pandas: The following messages are now emitted:

  1. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/_config/localization.py#L162
  2. invalid-name: Attribute name "a" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L434
  3. invalid-name: Attribute name "b" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L442
  4. invalid-name: Attribute name "c" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L447
  5. too-many-instance-attributes: Too many instance attributes (13/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/parsers/readers.py#L1380
  6. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style.py#L118
  7. invalid-name: Attribute name "y" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1770
  8. invalid-name: Attribute name "z" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1771
  9. invalid-name: Attribute name "Date" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L600
  10. invalid-name: Attribute name "oTime" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L636
  11. invalid-name: Attribute name "dt" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_timegrouper.py#L784
  12. invalid-name: Attribute name "x" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/aggregate/test_aggregate.py#L573
  13. invalid-name: Attribute name "A" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L142
  14. invalid-name: Attribute name "B" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L143
  15. invalid-name: Attribute name "C" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L144
  16. invalid-name: Attribute name "D" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L145
  17. invalid-name: Attribute name "h" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/indexing/test_setitem.py#L536
  18. too-many-instance-attributes: Too many instance attributes (31/11) https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L468
  19. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1003
  20. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1315
  21. invalid-name: Attribute name "tz" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L730
  22. redefined-variable-type: Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/api.py#L165
  23. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  24. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  25. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  26. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371

The following messages are no longer emitted:

  1. attribute-defined-outside-init: Attribute 'name' defined outside init https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9772
  2. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1003
  3. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1315
  4. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3010
  5. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3063
  6. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3124
  7. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3392
  8. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L4426
  9. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6061
  10. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6074
  11. redefined-variable-type: Redefinition of index type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/window/test_rolling.py#L715
  12. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/arithmetic/test_datetime64.py#L2302
  13. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.interval.IntervalIndex to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/dtypes/test_inference.py#L1664
  14. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L229
  15. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L230
  16. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.interval.IntervalIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/categorical/test_astype.py#L41
  17. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L180
  18. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L181
  19. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L187
  20. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  21. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  22. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  23. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371

Effect on sentry: The following messages are now emitted:

  1. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/getsentry/sentry/blob/master/src/sentry/eventstore/models.py#L34
  2. redefined-variable-type: Redefinition of orgs type from list to dict https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/relay/project_configs.py#L241
  3. not-callable: self.get_provider is not callable https://github.com/getsentry/sentry/blob/master/src/sentry/models/repository.py#L59
  4. too-many-instance-attributes: Too many instance attributes (23/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7
  5. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L264
  6. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L273

The following messages are no longer emitted:

  1. no-member: Instance of 'GzippedDictField' has no 'get' member https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L564
  2. unsubscriptable-object: Value 'self.data' is unsubscriptable https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L572
  3. too-many-instance-attributes: Too many instance attributes (20/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7
  4. import-error: Unable to import 'sentry.utils.distutils.commands.build_assets' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L3
  5. import-error: Unable to import 'sentry.utils.distutils.commands.build_integration_docs' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L4
  6. import-error: Unable to import 'sentry.utils.distutils.commands.build_js_sdk_registry' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L5
  7. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L12
  8. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L38
  9. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  10. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  11. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L45
  12. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L93
  13. attribute-defined-outside-init: Attribute 'asset_json_path' defined outside init https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L39
  14. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L13
  15. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  16. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  17. too-few-public-methods: Too few public methods (1/2) https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L39

This comment was generated for commit de60d26570c5c7ef9e8a487446c76914f89b5fdb

github-actions[bot] avatar Aug 10 '22 22:08 github-actions[bot]

🤖 Effect of this PR on checked open source code: 🤖

Effect on django: The following messages are no longer emitted:

  1. no-member: Instance of 'str' has no 'get' member https://github.com/django/django/blob/main/django/urls/resolvers.py#L642

Effect on pandas: The following messages are now emitted:

  1. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/_config/localization.py#L162
  2. invalid-name: Attribute name "a" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L434
  3. invalid-name: Attribute name "b" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L442
  4. invalid-name: Attribute name "c" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L447
  5. too-many-instance-attributes: Too many instance attributes (13/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/parsers/readers.py#L1381
  6. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style.py#L119
  7. invalid-name: Attribute name "y" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1770
  8. invalid-name: Attribute name "z" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1771
  9. invalid-name: Attribute name "Date" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L600
  10. invalid-name: Attribute name "oTime" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L636
  11. invalid-name: Attribute name "dt" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_timegrouper.py#L784
  12. invalid-name: Attribute name "x" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/aggregate/test_aggregate.py#L573
  13. invalid-name: Attribute name "A" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L142
  14. invalid-name: Attribute name "B" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L143
  15. invalid-name: Attribute name "C" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L144
  16. invalid-name: Attribute name "D" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L145
  17. invalid-name: Attribute name "h" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/indexing/test_setitem.py#L536
  18. too-many-instance-attributes: Too many instance attributes (31/11) https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L469
  19. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  20. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316
  21. invalid-name: Attribute name "tz" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L730
  22. redefined-variable-type: Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/api.py#L165
  23. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  24. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  25. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  26. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371

The following messages are no longer emitted:

  1. attribute-defined-outside-init: Attribute 'name' defined outside init https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9790
  2. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  3. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316
  4. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3011
  5. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3064
  6. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3125
  7. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3393
  8. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L4427
  9. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6062
  10. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6075
  11. redefined-variable-type: Redefinition of index type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/window/test_rolling.py#L715
  12. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/arithmetic/test_datetime64.py#L2302
  13. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.interval.IntervalIndex to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/dtypes/test_inference.py#L1664
  14. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L229
  15. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L230
  16. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.interval.IntervalIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/categorical/test_astype.py#L41
  17. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L180
  18. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L181
  19. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L187
  20. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  21. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  22. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  23. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371

Effect on sentry: The following messages are now emitted:

  1. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/getsentry/sentry/blob/master/src/sentry/eventstore/models.py#L34
  2. redefined-variable-type: Redefinition of orgs type from list to dict https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/relay/project_configs.py#L241
  3. not-callable: self.get_provider is not callable https://github.com/getsentry/sentry/blob/master/src/sentry/models/repository.py#L59
  4. too-many-instance-attributes: Too many instance attributes (23/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7
  5. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L264
  6. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L273

The following messages are no longer emitted:

  1. no-member: Instance of 'GzippedDictField' has no 'get' member https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L564
  2. unsubscriptable-object: Value 'self.data' is unsubscriptable https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L572
  3. too-many-instance-attributes: Too many instance attributes (20/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7
  4. import-error: Unable to import 'sentry.utils.distutils.commands.build_assets' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L3
  5. import-error: Unable to import 'sentry.utils.distutils.commands.build_integration_docs' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L4
  6. import-error: Unable to import 'sentry.utils.distutils.commands.build_js_sdk_registry' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L5
  7. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L12
  8. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L38
  9. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  10. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  11. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L45
  12. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L93
  13. attribute-defined-outside-init: Attribute 'asset_json_path' defined outside init https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L39
  14. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L13
  15. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  16. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  17. too-few-public-methods: Too few public methods (1/2) https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L39

This comment was generated for commit e79324d208c9ac2bf9dac750f23a8ff2fca015ee

github-actions[bot] avatar Aug 14 '22 20:08 github-actions[bot]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas: The following messages are now emitted:

  1. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  2. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316
  3. redefined-variable-type: Redefinition of indexer type from .ndarray to slice https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/multi.py#L3155
  4. redefined-variable-type: Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/api.py#L165
  5. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_localization.py#L140
  6. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  7. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.numeric.Int64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  8. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  9. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  10. no-member: Instance of 'DatetimeIndexOpsMixin' has no 'tz' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/methods/test_shift.py#L101
  11. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  12. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371

The following messages are no longer emitted:

  1. not-an-iterable: Non-iterable value index.values is used in an iterating context https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexing/multiindex/test_sorted.py#L120
  2. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  3. redefined-variable-type: Redefinition of result type from pandas.core.indexes.base.Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  4. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.interval.IntervalIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/categorical/test_astype.py#L41
  5. no-member: Instance of 'Index' has no 'day_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L249
  6. no-member: Instance of 'Index' has no 'month_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L274
  7. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  8. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  9. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  10. redefined-variable-type: Redefinition of idx1 type from pandas.core.indexes.period.PeriodIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_set_index.py#L516
  11. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371
  12. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.interval.IntervalIndex to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/dtypes/test_inference.py#L1664
  13. redefined-variable-type: Redefinition of key type from list to pandas.core.arrays.period.PeriodArray https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexing.py#L1391
  14. unsupported-assignment-operation: 'mangled_aggspec' does not support item assignment https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1540
  15. redefined-variable-type: Redefinition of mangled_aggspec type from str to list https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1542
  16. redefined-variable-type: Redefinition of indexer type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/algorithms.py#L1382
  17. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  18. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316

Effect on sentry: The following messages are now emitted:

  1. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/getsentry/sentry/blob/master/src/sentry/eventstore/models.py#L34
  2. too-many-instance-attributes: Too many instance attributes (23/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7
  3. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L264
  4. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L273

The following messages are no longer emitted:

  1. import-error: Unable to import 'sentry.utils.distutils.commands.build_assets' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L3
  2. import-error: Unable to import 'sentry.utils.distutils.commands.build_integration_docs' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L4
  3. import-error: Unable to import 'sentry.utils.distutils.commands.build_js_sdk_registry' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L5
  4. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L13
  5. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  6. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  7. too-few-public-methods: Too few public methods (1/2) https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L39
  8. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L12
  9. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L38
  10. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  11. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  12. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L45
  13. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L93
  14. attribute-defined-outside-init: Attribute 'asset_json_path' defined outside init https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L39
  15. no-member: Instance of 'Param' has no 'name' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/external_requests/issue_link_requester.py#L116
  16. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L25
  17. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L40
  18. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L58

This comment was generated for commit 662c19c2e30e9c5add02e54e7b1b1a561d7c3679

github-actions[bot] avatar Aug 15 '22 19:08 github-actions[bot]

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas: The following messages are now emitted:

  1. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_localization.py#L140
  2. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  3. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  4. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  5. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371
  6. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  7. redefined-variable-type: Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/api.py#L165
  8. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316

The following messages are no longer emitted:

  1. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  2. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.interval.IntervalIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/categorical/test_astype.py#L41
  3. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  4. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  5. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371
  6. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.interval.IntervalIndex to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/dtypes/test_inference.py#L1664
  7. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1008
  8. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316

Effect on sentry: The following messages are now emitted:

  1. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L264
  2. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L273
  3. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/getsentry/sentry/blob/master/src/sentry/eventstore/models.py#L34
  4. too-many-instance-attributes: Too many instance attributes (23/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7

The following messages are no longer emitted:

  1. import-error: Unable to import 'sentry.utils.distutils.commands.build_assets' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L3
  2. import-error: Unable to import 'sentry.utils.distutils.commands.build_integration_docs' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L4
  3. import-error: Unable to import 'sentry.utils.distutils.commands.build_js_sdk_registry' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L5
  4. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L13
  5. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  6. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  7. too-few-public-methods: Too few public methods (1/2) https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L39
  8. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L12
  9. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L38
  10. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  11. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  12. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L45
  13. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L93
  14. attribute-defined-outside-init: Attribute 'asset_json_path' defined outside init https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L39
  15. no-member: Instance of 'Param' has no 'name' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/external_requests/issue_link_requester.py#L116
  16. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L25
  17. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L40
  18. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L58

This comment was generated for commit 36740d3c74845eafd7b627bc5c30747744196c2d

github-actions[bot] avatar Aug 15 '22 20:08 github-actions[bot]

@Pierre-Sassoulas Gentle ping as this is very prone to creating merge conflicts and I'd like to merge quickyl

DanielNoord avatar Aug 17 '22 13:08 DanielNoord

🤖 Effect of this PR on checked open source code: 🤖

Effect on pandas: The following messages are now emitted:

  1. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_localization.py#L140
  2. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  3. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  4. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  5. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371
  6. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1068
  7. redefined-variable-type: Redefinition of index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/api.py#L165
  8. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.datetimes.DatetimeIndex https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316

The following messages are no longer emitted:

  1. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.period.PeriodIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/period/test_indexing.py#L615
  2. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.interval.IntervalIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/categorical/test_astype.py#L41
  3. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L142
  4. redefined-variable-type: Redefinition of i2 type from pandas.core.indexes.numeric.Float64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_indexing.py#L212
  5. redefined-variable-type: Redefinition of columns type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_reset_index.py#L371
  6. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.interval.IntervalIndex to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/dtypes/test_inference.py#L1664
  7. redefined-variable-type: Redefinition of join_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/reshape/merge.py#L1068
  8. redefined-variable-type: Redefinition of new_index type from pandas.core.indexes.base.Index to pandas.core.indexes.numeric.Float64Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L1316

Effect on sentry: The following messages are now emitted:

  1. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L264
  2. unneeded-not: Consider changing "not settings.SENTRY_EVENTSTREAM == 'sentry.eventstream.kafka.KafkaEventStream'" to "settings.SENTRY_EVENTSTREAM != 'sentry.eventstream.kafka.KafkaEventStream'" https://github.com/getsentry/sentry/blob/master/src/sentry/runner/commands/devserver.py#L273
  3. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/getsentry/sentry/blob/master/src/sentry/eventstore/models.py#L34
  4. too-many-instance-attributes: Too many instance attributes (23/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7

The following messages are no longer emitted:

  1. import-error: Unable to import 'sentry.utils.distutils.commands.build_assets' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L3
  2. import-error: Unable to import 'sentry.utils.distutils.commands.build_integration_docs' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L4
  3. import-error: Unable to import 'sentry.utils.distutils.commands.build_js_sdk_registry' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/init.py#L5
  4. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L13
  5. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  6. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L42
  7. too-few-public-methods: Too few public methods (1/2) https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_js_sdk_registry.py#L39
  8. import-error: Unable to import 'sentry.utils.distutils.commands.base' https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L12
  9. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L38
  10. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  11. no-self-use: Method could be a function https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L42
  12. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L45
  13. missing-function-docstring: Missing function or method docstring https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L93
  14. attribute-defined-outside-init: Attribute 'asset_json_path' defined outside init https://github.com/getsentry/sentry/blob/master/src/sentry/utils/distutils/commands/build_assets.py#L39
  15. no-member: Instance of 'Param' has no 'name' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/external_requests/issue_link_requester.py#L116
  16. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L25
  17. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L40
  18. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L58

This comment was generated for commit 1147c080abb6bd8effa3bbffd5227b96eafcae9c

github-actions[bot] avatar Aug 17 '22 14:08 github-actions[bot]

LGTM ! Sorry for the delay, it was a little hard to review as it seems the code was moved around but the diff is not very helpful. And sometime it's more than moving around (like the fatal/astroid-error change).

No worries, just thought you might have missed this as you had reviewed more recent PRs. Thanks for the review 😄

DanielNoord avatar Aug 17 '22 15:08 DanielNoord