pylint icon indicating copy to clipboard operation
pylint copied to clipboard

Published 20 hours ago β€’ verified publisher icon pylint-dev

Add ``invalid-name`` check for ``TypeAlias`` names

Open DanielNoord opened this issue 3 years ago β€’ 5 comments

  • [x] Write a good description on what the PR does.
  • [x] Add an entry to the change log describing the change in doc/whatsnew/2/2.15/index.rst (or doc/whatsnew/2/2.14/full.rst if the change needs backporting in 2.14). If necessary you can write details or offer examples on how the new change is supposed to work.
  • [x] If you used multiple emails or multiple names when contributing, add your mails and preferred name in script/.contributors_aliases.json

Type of Changes

Type
βœ“ :sparkles: New feature

Description

Closes #7081.

DanielNoord avatar Jul 03 '22 14:07 DanielNoord

Pull Request Test Coverage Report for Build 3403162957

  • 30 of 32 (93.75%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 95.376%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pylint/checkers/base/name_checker/checker.py 28 30 93.33%
<!-- Total: 30 32
Totals Coverage Status
Change from base Build 3401220436: -0.004%
Covered Lines: 17266
Relevant Lines: 18103
πŸ’› - Coveralls

coveralls avatar Jul 03 '22 14:07 coveralls

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L55
  2. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L61
  3. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L62
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L43
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L11
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L19
  7. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L39
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L20
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L280
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L297
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L320
  4. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L149
  5. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  6. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L104
  7. invalid-name: Type alias name "CSSProperties" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style_render.py#L53

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20

This comment was generated for commit 70048ba26dbc669f2e950c9a9773635560825840

github-actions[bot] avatar Jul 03 '22 15:07 github-actions[bot]

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L55
  2. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L61
  3. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L62
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L43
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L11
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L19
  7. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L39
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L20
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L280
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L297
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L320
  4. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L150
  5. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  6. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L106
  7. invalid-name: Type alias name "CSSProperties" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style_render.py#L53

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20

This comment was generated for commit 8a66675ff39f5691f4879cabe0bca691b3a8247b

github-actions[bot] avatar Jul 07 '22 08:07 github-actions[bot]

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L43
  2. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L39
  3. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L20
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L11
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L55
  6. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L61
  7. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L62
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L19
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L280
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L297
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L320
  4. invalid-name: Type alias name "CSSProperties" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style_render.py#L53
  5. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  6. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L109
  7. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L150

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20
  2. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L145

This comment was generated for commit 53c89fd08125d8e85308b02ee1b3545dcc69e018

github-actions[bot] avatar Jul 21 '22 14:07 github-actions[bot]

@cdce8p Just checking in. Do you want to review this before we merge this? Or can we merge without a review by you.

DanielNoord avatar Aug 09 '22 20:08 DanielNoord

@cdce8p Changed the regex. Let me know what you think.

This doesn't allow TBADname but I don't think there is a good way to reliably distinguish between TESTType and TTest. As in, when a T in the first place is a prefix or part of a longer word.

DanielNoord avatar Aug 16 '22 12:08 DanielNoord

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L65
  2. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L71
  3. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L72
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L10
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L68
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L31
  7. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L28
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L24
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56
  10. invalid-name: Type alias name "TokenInfo" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pgen2/tokenize.py#L229

Effect on django: The following messages are no longer emitted:

  1. no-member: Instance of 'str' has no 'get' member https://github.com/django/django/blob/main/django/urls/resolvers.py#L642

Effect on flask: The following messages are now emitted:

  1. invalid-name: Type alias name "TeardownCallable" doesn't conform to predefined naming style https://github.com/pallets/flask/blob/main/src/flask/typing.py#L58

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "TimestampConvertibleTypes" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L93
  2. invalid-name: Type alias name "TimedeltaConvertibleTypes" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L96
  3. invalid-name: Type alias name "Timezone" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L99
  4. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L279
  5. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L296
  6. invalid-name: Type alias name "TakeIndexer" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L298
  7. not-an-iterable: Non-iterable value index.values is used in an iterating context https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexing/multiindex/test_sorted.py#L120
  8. redefined-variable-type: Redefinition of result type from pandas.core.indexes.base.Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  9. no-member: Instance of 'Index' has no 'day_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L249
  10. no-member: Instance of 'Index' has no 'month_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L274
  11. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  12. redefined-variable-type: Redefinition of idx1 type from pandas.core.indexes.period.PeriodIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_set_index.py#L516
  13. redefined-variable-type: Redefinition of key type from list to pandas.core.arrays.period.PeriodArray https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexing.py#L1391
  14. invalid-name: Attribute name "y" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1770
  15. invalid-name: Attribute name "z" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1771
  16. invalid-name: Attribute name "dt" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_timegrouper.py#L784
  17. invalid-name: Attribute name "Date" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L600
  18. invalid-name: Attribute name "oTime" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L636
  19. invalid-name: Attribute name "x" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/aggregate/test_aggregate.py#L589
  20. invalid-name: Attribute name "A" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L142
  21. invalid-name: Attribute name "B" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L143
  22. invalid-name: Attribute name "C" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L144
  23. invalid-name: Attribute name "D" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L145
  24. invalid-name: Attribute name "h" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/indexing/test_setitem.py#L536
  25. too-many-instance-attributes: Too many instance attributes (31/11) https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L471
  26. unsupported-assignment-operation: 'mangled_aggspec' does not support item assignment https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1540
  27. redefined-variable-type: Redefinition of mangled_aggspec type from str to list https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1542
  28. redefined-variable-type: Redefinition of indexer type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/algorithms.py#L1382
  29. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L151
  30. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  31. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L110
  32. invalid-name: Attribute name "tz" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L730
  33. invalid-name: Attribute name "a" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L434
  34. invalid-name: Attribute name "b" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L442
  35. invalid-name: Attribute name "c" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L447
  36. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/_config/localization.py#L162
  37. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style.py#L119
  38. too-many-instance-attributes: Too many instance attributes (13/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/parsers/readers.py#L1381

The following messages are no longer emitted:

  1. attribute-defined-outside-init: Attribute 'name' defined outside init https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9724
  2. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3011
  3. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3064
  4. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3125
  5. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3393
  6. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L4427
  7. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6062
  8. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6075
  9. redefined-variable-type: Redefinition of indexer type from .ndarray to slice https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/multi.py#L3155
  10. redefined-variable-type: Redefinition of index type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/window/test_rolling.py#L715
  11. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/arithmetic/test_datetime64.py#L2302
  12. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_localization.py#L140
  13. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L229
  14. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L230
  15. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  16. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.numeric.Int64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  17. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L180
  18. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L181
  19. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L187
  20. no-member: Instance of 'DatetimeIndexOpsMixin' has no 'tz' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/methods/test_shift.py#L101

Effect on sentry: The following messages are now emitted:

  1. not-callable: self.get_provider is not callable https://github.com/getsentry/sentry/blob/master/src/sentry/models/repository.py#L65
  2. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L145
  3. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20
  4. invalid-name: Type alias name "TagValue" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/utils/metrics.py#L40
  5. no-member: Instance of 'Param' has no 'name' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/external_requests/issue_link_requester.py#L116
  6. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L25
  7. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L40
  8. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L58
  9. redefined-variable-type: Redefinition of orgs type from list to dict https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/relay/project_configs.py#L241

The following messages are no longer emitted:

  1. no-member: Instance of 'GzippedDictField' has no 'get' member https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L564
  2. unsubscriptable-object: Value 'self.data' is unsubscriptable https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L572
  3. too-many-instance-attributes: Too many instance attributes (20/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7

This comment was generated for commit c0a14f06c45469059ac65c74e339afafcacb66c7

github-actions[bot] avatar Aug 16 '22 13:08 github-actions[bot]

After the primer comment I think it's better to not worry about the T. TokenInfo such as in black shouldn't really be flagged. Making changes.

DanielNoord avatar Aug 16 '22 19:08 DanielNoord

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L65
  2. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L10
  3. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L68
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L31
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L28
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L24
  7. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on django: The following messages are no longer emitted:

  1. no-member: Instance of 'str' has no 'get' member https://github.com/django/django/blob/main/django/urls/resolvers.py#L642

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L279
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L296
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L319
  4. not-an-iterable: Non-iterable value index.values is used in an iterating context https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexing/multiindex/test_sorted.py#L120
  5. redefined-variable-type: Redefinition of result type from pandas.core.indexes.base.Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  6. no-member: Instance of 'Index' has no 'day_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L249
  7. no-member: Instance of 'Index' has no 'month_name' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L274
  8. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  9. redefined-variable-type: Redefinition of idx1 type from pandas.core.indexes.period.PeriodIndex to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/methods/test_set_index.py#L516
  10. redefined-variable-type: Redefinition of key type from list to pandas.core.arrays.period.PeriodArray https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexing.py#L1391
  11. invalid-name: Attribute name "y" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1770
  12. invalid-name: Attribute name "z" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/reshape/test_pivot.py#L1771
  13. invalid-name: Attribute name "dt" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_timegrouper.py#L784
  14. invalid-name: Attribute name "Date" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L600
  15. invalid-name: Attribute name "oTime" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/test_apply.py#L636
  16. invalid-name: Attribute name "x" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/groupby/aggregate/test_aggregate.py#L589
  17. invalid-name: Attribute name "A" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L142
  18. invalid-name: Attribute name "B" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L143
  19. invalid-name: Attribute name "C" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L144
  20. invalid-name: Attribute name "D" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/conftest.py#L145
  21. invalid-name: Attribute name "h" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/frame/indexing/test_setitem.py#L536
  22. too-many-instance-attributes: Too many instance attributes (31/11) https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L471
  23. unsupported-assignment-operation: 'mangled_aggspec' does not support item assignment https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1540
  24. redefined-variable-type: Redefinition of mangled_aggspec type from str to list https://github.com/pandas-dev/pandas/blob/main/pandas/core/apply.py#L1542
  25. redefined-variable-type: Redefinition of indexer type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.base.Index https://github.com/pandas-dev/pandas/blob/main/pandas/core/algorithms.py#L1382
  26. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L151
  27. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  28. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L110
  29. invalid-name: Attribute name "tz" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L730
  30. invalid-name: Attribute name "a" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L434
  31. invalid-name: Attribute name "b" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L442
  32. invalid-name: Attribute name "c" doesn't conform to '[a-z_][a-z0-9_]{2,}$' pattern https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_config.py#L447
  33. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/_config/localization.py#L162
  34. too-many-instance-attributes: Too many instance attributes (12/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/formats/style.py#L119
  35. too-many-instance-attributes: Too many instance attributes (13/11) https://github.com/pandas-dev/pandas/blob/main/pandas/io/parsers/readers.py#L1381

The following messages are no longer emitted:

  1. attribute-defined-outside-init: Attribute 'name' defined outside init https://github.com/pandas-dev/pandas/blob/main/pandas/core/frame.py#L9724
  2. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3011
  3. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3064
  4. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3125
  5. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L3393
  6. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L4427
  7. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6062
  8. using-constant-test: Using a conditional statement with a constant value https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/base.py#L6075
  9. redefined-variable-type: Redefinition of indexer type from .ndarray to slice https://github.com/pandas-dev/pandas/blob/main/pandas/core/indexes/multi.py#L3155
  10. redefined-variable-type: Redefinition of index type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/window/test_rolling.py#L715
  11. redefined-variable-type: Redefinition of idx type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.datetimelike.DatetimeTimedeltaMixin https://github.com/pandas-dev/pandas/blob/main/pandas/tests/arithmetic/test_datetime64.py#L2302
  12. no-member: Instance of 'int' has no 'encoding' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/config/test_localization.py#L140
  13. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L229
  14. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_convert' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/io/pytables/test_timezones.py#L230
  15. redefined-variable-type: Redefinition of result type from pandas.core.indexes.numeric.Int64Index to pandas.core.indexes.multi.MultiIndex https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/multi/test_reshape.py#L126
  16. redefined-variable-type: Redefinition of dti type from pandas.core.indexes.datetimes.DatetimeIndex to pandas.core.indexes.numeric.Int64Index https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_misc.py#L248
  17. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L180
  18. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L181
  19. no-member: Instance of 'DatetimeTimedeltaMixin' has no 'tz_localize' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/test_constructors.py#L187
  20. no-member: Instance of 'DatetimeIndexOpsMixin' has no 'tz' member https://github.com/pandas-dev/pandas/blob/main/pandas/tests/indexes/datetimes/methods/test_shift.py#L101

Effect on sentry: The following messages are now emitted:

  1. not-callable: self.get_provider is not callable https://github.com/getsentry/sentry/blob/master/src/sentry/models/repository.py#L65
  2. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L145
  3. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20
  4. no-member: Instance of 'Param' has no 'name' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/external_requests/issue_link_requester.py#L116
  5. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L25
  6. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L40
  7. no-member: Instance of 'Param' has no 'schema' member https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/sentry_app_components/preparer.py#L58
  8. redefined-variable-type: Redefinition of orgs type from list to dict https://github.com/getsentry/sentry/blob/master/src/sentry/api/endpoints/relay/project_configs.py#L241

The following messages are no longer emitted:

  1. no-member: Instance of 'GzippedDictField' has no 'get' member https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L564
  2. unsubscriptable-object: Value 'self.data' is unsubscriptable https://github.com/getsentry/sentry/blob/master/src/sentry/models/group.py#L572
  3. too-many-instance-attributes: Too many instance attributes (20/11) https://github.com/getsentry/sentry/blob/master/src/sentry/mediators/param.py#L7

This comment was generated for commit e4af2b6cd7bbed174530cecf4513986dca5c408a

github-actions[bot] avatar Aug 16 '22 19:08 github-actions[bot]

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L65
  2. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L10
  3. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L68
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L31
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L28
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L24
  7. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L279
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L296
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L319
  4. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L151
  5. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  6. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L106

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L145
  2. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20

This comment was generated for commit 514324d733e0fa4ae3244b4e391269587dcd1133

github-actions[bot] avatar Aug 19 '22 10:08 github-actions[bot]

Check fail should be fixed by https://github.com/PyCQA/pylint/pull/7321

Pierre-Sassoulas avatar Aug 19 '22 10:08 Pierre-Sassoulas

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/main/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L65
  2. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L71
  3. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/trans.py#L72
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/debug.py#L10
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/linegen.py#L68
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/nodes.py#L31
  7. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/brackets.py#L28
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/black/comments.py#L24
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/main/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L279
  2. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L296
  3. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/_typing.py#L319
  4. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/datetimelike.py#L151
  5. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/string_arrow.py#L53
  6. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/main/pandas/core/arrays/interval.py#L106

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/testutils/cases.py#L145
  2. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/master/src/sentry/shared_integrations/client/base.py#L20

This comment was generated for commit 7cb9746dbd2a503871f0de149064514ad683af16

github-actions[bot] avatar Aug 21 '22 12:08 github-actions[bot]

Can I help forward this at all? I hate to see all this work go stale for 4 months

jamesbraza avatar Nov 05 '22 22:11 jamesbraza

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/4acf5785c54f4ccb8f41402991f6ddc5d8b28b89/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/trans.py#L65
  2. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/trans.py#L71
  3. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/trans.py#L72
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/brackets.py#L28
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/debug.py#L10
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/linegen.py#L68
  7. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/nodes.py#L31
  8. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/black/comments.py#L25
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/0e9d29ab73d608a79028e22a713ee717b5dcca96/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "ScalarLike_co" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/_typing.py#L68
  2. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/_typing.py#L290
  3. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/_typing.py#L307
  4. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/_typing.py#L330
  5. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/core/arrays/interval.py#L106
  6. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/core/arrays/string_arrow.py#L48
  7. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/core/arrays/datetimelike.py#L157

The following messages are no longer emitted:

  1. invalid-name: Class name "ScalarLike_co" doesn't conform to '[A-Z_][a-zA-Z0-9]+$' pattern https://github.com/pandas-dev/pandas/blob/fa41c52c3dec0597a39910ade667084a16169b28/pandas/_typing.py#L68

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/7599f2dfd8eff4c14a7a3f254d45bd2fdb20ef96/src/sentry/shared_integrations/client/base.py#L20
  2. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/7599f2dfd8eff4c14a7a3f254d45bd2fdb20ef96/src/sentry/testutils/cases.py#L159

This comment was generated for commit 08819ba8f35d9cb411e4d40eff914e324b2550f6

github-actions[bot] avatar Nov 06 '22 06:11 github-actions[bot]

Can I help forward this at all? I hate to see all this work go stale for 4 months

I'll take another look at it soon.

cdce8p avatar Nov 06 '22 09:11 cdce8p

Can I help forward this at all? I hate to see all this work go stale for 4 months

I'll take another look at it soon.

@cdce8p Do you think you'll be able to have a look at this still?

DanielNoord avatar Jan 29 '23 19:01 DanielNoord

@Pierre-Sassoulas I would prefer to merge this even without the final review from Marc. If we get feedback on the regex we can always change it, but the underlying changes seem good to me. Are you okay with this?

DanielNoord avatar Feb 26 '23 17:02 DanielNoord

Yeah allright, let's merge.

Pierre-Sassoulas avatar Feb 26 '23 18:02 Pierre-Sassoulas

Codecov Report

Merging #7116 (20ad037) into main (27a3984) will increase coverage by 0.00%. The diff coverage is 96.49%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7116   +/-   ##
=======================================
  Coverage   95.47%   95.47%           
=======================================
  Files         177      178    +1     
  Lines       18726    18776   +50     
=======================================
+ Hits        17878    17926   +48     
- Misses        848      850    +2
Impacted Files Coverage Ξ”
pylint/checkers/base/name_checker/naming_style.py 100.00% <ΓΈ> (ΓΈ)
pylint/constants.py 100.00% <ΓΈ> (ΓΈ)
pylint/checkers/base/name_checker/checker.py 98.60% <93.54%> (-0.64%) :arrow_down:
pylint/checkers/bad_chained_comparison.py 100.00% <100.00%> (ΓΈ)
pylint/utils/linterstats.py 96.47% <100.00%> (+0.04%) :arrow_up:

codecov[bot] avatar Feb 26 '23 19:02 codecov[bot]

Had to completely rebase as I was getting a lot of CI issues. Sorry for the loss of history, but this was the most sane way to do this.

DanielNoord avatar Feb 26 '23 20:02 DanielNoord

Also note that the recent PR broke main. I included a commit to fix this.

DanielNoord avatar Feb 26 '23 20:02 DanielNoord

πŸ€– Effect of this PR on checked open source code: πŸ€–

Effect on astroid: The following messages are now emitted:

  1. invalid-name: Type alias name "SkipKlassT" doesn't conform to predefined naming style https://github.com/PyCQA/astroid/blob/fe5776279506e9fad59f0a4b850b6fa3e1a4220f/astroid/nodes/node_ng.py#L56

Effect on black: The following messages are now emitted:

  1. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/brackets.py#L28
  2. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/nodes.py#L31
  3. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/debug.py#L10
  4. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/comments.py#L25
  5. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/linegen.py#L78
  6. invalid-name: Type alias name "LN" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/trans.py#L65
  7. invalid-name: Type alias name "TResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/trans.py#L71
  8. invalid-name: Type alias name "TMatchResult" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/black/trans.py#L72
  9. invalid-name: Type alias name "NL" doesn't conform to predefined naming style https://github.com/psf/black/blob/d9b8a6407e2f46304a8d36b18e4a73d8e0613519/src/blib2to3/pytree.py#L56

Effect on pandas: The following messages are now emitted:

  1. invalid-name: Type alias name "ScalarLike_co" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/_typing.py#L72
  2. invalid-name: Type alias name "Manager2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/_typing.py#L302
  3. invalid-name: Type alias name "PositionalIndexer2D" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/_typing.py#L319
  4. invalid-name: Type alias name "DatetimeNaTType" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/_typing.py#L345
  5. invalid-name: Type alias name "DTScalarOrNaT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/core/arrays/datetimelike.py#L157
  6. invalid-name: Type alias name "ArrowStringScalarOrNAT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/core/arrays/string_arrow.py#L49
  7. invalid-name: Type alias name "IntervalSideT" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/core/arrays/interval.py#L111
  8. invalid-name: Type alias name "IntervalOrNA" doesn't conform to predefined naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/core/arrays/interval.py#L112

The following messages are no longer emitted:

  1. invalid-name: Class name "ScalarLike_co" doesn't conform to PascalCase naming style https://github.com/pandas-dev/pandas/blob/9203f9e90a5548275769b17f85b1fa06ec69e011/pandas/_typing.py#L72

Effect on sentry: The following messages are now emitted:

  1. invalid-name: Type alias name "BaseApiResponseX" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/73dc9823fffc8a275071a5bb513f8610ea3f13b5/src/sentry/shared_integrations/client/base.py#L21
  2. invalid-name: Type alias name "SessionOrTransactionMRI" doesn't conform to predefined naming style https://github.com/getsentry/sentry/blob/73dc9823fffc8a275071a5bb513f8610ea3f13b5/src/sentry/testutils/cases.py#L169

Effect on coverage: The following messages are now emitted:

  1. invalid-name: Type alias name "TTraceFileData" doesn't conform to predefined naming style https://github.com/nedbat/coveragepy/blob/499f4f52f738fac6133c9889b4a94b998628ac6f/coverage/types.py#L77
  2. invalid-name: Type alias name "TMorf" doesn't conform to predefined naming style https://github.com/nedbat/coveragepy/blob/499f4f52f738fac6133c9889b4a94b998628ac6f/coverage/types.py#L159
  3. invalid-name: Type alias name "TConfigParser" doesn't conform to predefined naming style https://github.com/nedbat/coveragepy/blob/499f4f52f738fac6133c9889b4a94b998628ac6f/coverage/config.py#L148

This comment was generated for commit 20ad03733ffd643287c7c9154f9298788946900c

github-actions[bot] avatar Feb 26 '23 21:02 github-actions[bot]