aiotdlib icon indicating copy to clipboard operation
aiotdlib copied to clipboard

pypi packaging improvements

Open truenicoco opened this issue 3 years ago • 3 comments

There are some problems with the pypi package:

  • the .tar.gz actually contains linux/amd64 and darwin/arm64 binaries for tdlib but are supposed to be source only
  • the .whl is tagged architecture "none", but actually only works on linux/amd64 and darwin/arm64

I know this is in the README, but since I have a project depending on aiotdlib and proper multiarch packaging would be great for it, I might submit a MR to have this properly done via github actions. Would you accept it? (not promising any timeline here ;))

truenicoco avatar Sep 20 '22 08:09 truenicoco

Sure! Feel free to open any PR 😉

pylakey avatar Sep 20 '22 22:09 pylakey

Poetry has no stable API to do this, but here's an example of a project that hacked something to do it anyway:

https://github.com/sdispater/pendulum/blob/master/pyproject.toml#L67

I have not attempted it yet, but I guess we can try to do it the same way.

@pylakey did you apply some patches in your tdlib fork? In other words, do we have to use your fork of tdlib or can we just checkout to a specific commit from the main tdlib source?

truenicoco avatar Oct 14 '22 19:10 truenicoco

I've only added binary building with github actions to tdlib fork. No patches are aplied to original codebase

pylakey avatar Oct 18 '22 22:10 pylakey

Did you close because of inactivity or because you're against the idea? I planned on giving this a new try this summer. This lib is great and I'm happy to use it, but having non-conform wheels on PyPI makes it very complicated to publish software depending on it. Providing tdlib binaries for all platforms is probably complicated, but packaging it in a way that makes it possible to build from source when build dependencies are available would be excellent… would you accept a PR in this direction?

truenicoco avatar Jun 18 '24 07:06 truenicoco

When PR is ready, let's get back to this discussion)

pylakey avatar Jun 18 '24 22:06 pylakey