pyjanitor icon indicating copy to clipboard operation
pyjanitor copied to clipboard

Published 20 hours ago • verified publisher icon pyjanitor-devs

`row_to_names` improvement

Open samukweku opened this issue 1 year ago • 2 comments

PR Description

Please describe the changes proposed in the pull request:

  • minor speed improvement for polars row_to_names
  • lazyframe not supported; the collect method cannot be avoided here.
  • minor changes for pandas' row_to_names

This PR relates to #1352 .

samukweku avatar Jun 20 '24 12:06 samukweku

🚀 Deployed on https://deploy-preview-1379--pyjanitor.netlify.app

ericmjl avatar Jun 20 '24 12:06 ericmjl

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 87.36%. Comparing base (62c57c6) to head (9010b06). Report is 25 commits behind head on dev.

:exclamation: Current head 9010b06 differs from pull request most recent head ff82eba

Please upload reports for the commit ff82eba to get more accurate results.

Additional details and impacted files 
@@            Coverage Diff             @@
##              dev    #1379      +/-   ##
==========================================
- Coverage   94.48%   87.36%   -7.12%     
==========================================
  Files          80       86       +6     
  Lines        4367     5067     +700     
==========================================
+ Hits         4126     4427     +301     
- Misses        241      640     +399

codecov[bot] avatar Jun 20 '24 23:06 codecov[bot]

I am going to merge!

ericmjl avatar Jul 13 '24 22:07 ericmjl