pyjanitor icon indicating copy to clipboard operation
pyjanitor copied to clipboard

`convert_excel_date`, `convert_matlab_date` for Polars

Open samukweku opened this issue 1 year ago • 3 comments

PR Description

Please describe the changes proposed in the pull request:

  • Add convert_excel_date, convert_matlab_date for polars
  • deprecate convert_unix_date
  • update convert_excel_date and convert_matlab_date source code for pandas (vectorized pandas operations)
  • avoid dataframe mutation in pandas

This PR relates to #1352 .

PR Checklist

Please ensure that you have done the following:

  1. [x] PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. [x] If you're not on the contributors list, add yourself to AUTHORS.md.
  1. [x] Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

  • @ericmjl

samukweku avatar May 21 '24 23:05 samukweku

🚀 Deployed on https://deploy-preview-1365--pyjanitor.netlify.app

ericmjl avatar May 21 '24 23:05 ericmjl

@ericmjl I made some changes to #1363 ... open to feedback on a better way

samukweku avatar Jun 10 '24 14:06 samukweku

@samukweku looks like we have some conflicts to resolve on this branch, and then we can merge!

ericmjl avatar Jun 21 '24 02:06 ericmjl