pyiron_base icon indicating copy to clipboard operation
pyiron_base copied to clipboard

Fixes for the `pack()` and `unpack()` method

Open jan-janssen opened this issue 11 months ago • 4 comments

@jyang2009 based on our discussion I created a couple of fixes for the pack() and unpack() method. Can you check if these resolve the issues you had with archiving on ptmp?

jan-janssen avatar Mar 28 '24 14:03 jan-janssen

Hi Jan,

I've tested this fix but got a new error when using the copy_to function. I copy the error below. Screen Shot 2024-04-05 at 1 45 41 PM

Best, Jing

jyang2009 avatar Apr 05 '24 11:04 jyang2009

@jyang2009 Can you provide a bit more details about the commands you were executing that resulted in this error?

jan-janssen avatar Apr 05 '24 18:04 jan-janssen

Hi Jan,

I just used the code that I used to copy jobs to the new project, which was working previously. pr_archive = Project("archive") job_new = job.copy_to(project=pr_archive)

jyang2009 avatar Apr 07 '24 16:04 jyang2009

Hi Jan,

I've tested this fix but got a new error when using the copy_to function. I copy the error below.

Best, Jing

Hi Jing,

I am sorry for the delay. The error message basically says, that pr_archive is not a recognised data type. You can check the data type using:

type(pr_archive)

My assumption would be it is just a str or a Path object. In those cases you can create a project from it using:

pr_archive=Project(pr_archive)

This should resolve this issue.

Best,

Jan

jan-janssen avatar Apr 19 '24 19:04 jan-janssen

@samwaseda Originally I was waiting for feedback from @jyang2009 if this solves her problem, as from my side this looks ready to be merged.

jan-janssen avatar May 23 '24 12:05 jan-janssen

Side note: I don't think the csv file should be separated from the tar file, so I will probably remove it entirely in this PR

samwaseda avatar May 23 '24 13:05 samwaseda

Did this one actually solve the issue @jyang2009 ? Otherwise I would like to revert it because I find it actually pretty dangerous that it looks for the csv file everywhere.

samwaseda avatar Aug 15 '24 08:08 samwaseda

@jyang2009 sort of confirmed that the error that she was getting was not related to unpack. So I'm gonna partly revert the changes here.

samwaseda avatar Aug 15 '24 20:08 samwaseda