pyinstaller icon indicating copy to clipboard operation
pyinstaller copied to clipboard

Ask maintainers of (major) libraries to provide hook

Open htgoebel opened this issue 5 years ago • 11 comments

Now that PyInstaller allows package developers to provide hooks with their packages, we might ask developers of other (major) packages to do so.

Template for a possible text (adobt you your needs and personal style :-):

PyInstaller developer here.

PyInstaller includes a ["hook" for adapting it to the special needs and methods of XXX](https://pyinstaller.readthedocs.io/en/stable/hooks.html). This works quite well, anyway if XXX changes, it might take some time until PyInstaller catches up.

PyInstaller 4.0 (released a few weeks ago) added support for package developers to provide hooks with their packages. Thus numpy could deliver hooks including or excluding modules and files as needed. If you are interested in providing PyInstaller hooks with numpy, please have a look at [package developers to provide hooks with their packages](https://pyinstaller.readthedocs.io/en/stable/hooks.html#provide-hooks-with-package).

htgoebel avatar Aug 29 '20 14:08 htgoebel

https://github.com/numpy/numpy/issues/17184

htgoebel avatar Aug 29 '20 14:08 htgoebel

@htgoebel I'm already on this with numpy and matplotlib, and I've talked to the developers of both. My PRs should be open within the week.

Legorooj avatar Aug 29 '20 22:08 Legorooj

I'd suggest @Legorooj helping assign a dev to support package devs -- for example, perhaps he would help answer any numpy/sympy questions that team has, etc. I'd also suggest providing contact info in the submitted PR -- "this person will be happy to help you develop and maintain your hook" -- to get the ball rolling.

bjones1 avatar Aug 31 '20 16:08 bjones1

Good idea! And of course we should provide any existing hook.

htgoebel avatar Aug 31 '20 17:08 htgoebel

Ok - which developers are willing to do this? I mean move a hook to it's supporting library (except numpy, matplotlib, cryptography, and pycryptodome; I'll do those), and offer continued support to that development team/person if they need help? You'll be able to ask for help from the rest of us you'd just be the primary contact for them.

CC'ing @bwoodsend @vitsensei @amifunny @motatoes @RS357 @rokm @reritom

Legorooj avatar Sep 01 '20 09:09 Legorooj

I volunteer as a tribute @Legorooj

motatoes avatar Sep 01 '20 09:09 motatoes

I'm pretty familiar with the numpy and matplotlib hooks so happy to help with those two. The cryptography ones I've never even looked at so best give those to someone else...

bwoodsend avatar Sep 01 '20 09:09 bwoodsend

@bwoodsend feel free to take over on numpy and matplotlib - you're probably more familiar than I am.

Legorooj avatar Sep 01 '20 10:09 Legorooj

What things are needed to be told to maintainers of other libraries, in order for them to maintain the hooks?

amifunny avatar Sep 01 '20 17:09 amifunny

@amifunny https://pyinstaller.readthedocs.io/en/stable/hooks.html#provide-hooks-with-package should provide enough information. Other package's maintainers (OPMs ;-) are recommended to test their hooks against the current stable release of PyInstaller (pip install pyinstaller>=4.0, pinning this is not recommended) and the development branch pip install https://github.com/pyinstaller/pyinstaller/archive/develop.targ.bz2. An example can be found in https://github.com/pyinstaller/hooksample

htgoebel avatar Sep 03 '20 06:09 htgoebel

Also see the setup in hooks-contrib, which is very similar to what OPMs would need.

Legorooj avatar Sep 04 '20 03:09 Legorooj