pyinfra icon indicating copy to clipboard operation
pyinfra copied to clipboard

Support more arguments in FindFilesBase

Open JakkuSakura opened this issue 1 year ago • 3 comments

This is an attempt to make FindFiles more useful.

~It has not been tested yet~

closes #1174

JakkuSakura avatar Aug 27 '24 18:08 JakkuSakura

Just fixed linting. one notable change is fname mypy caught that name is defined in FactBase, thus we can't use name directly

JakkuSakura avatar Sep 02 '24 16:09 JakkuSakura

I'm not sure how to express args: List[str] especially it may contain QuoteString

JakkuSakura avatar Sep 04 '24 14:09 JakkuSakura

finally... I also managed to enhance the tests to support dict as argument.

JakkuSakura avatar Sep 05 '24 04:09 JakkuSakura

Much appreciated! It's my first PR for pyinfra and the lining has cost me some time, but eventually figured out how to do it properly

JakkuSakura avatar Nov 16 '24 18:11 JakkuSakura

Much appreciated! It's my first PR for pyinfra and the lining has cost me some time, but eventually figured out how to do it properly

Would love any comments/ideas/etc on how to make the experience better when contributing 🙏

Fizzadar avatar Nov 16 '24 21:11 Fizzadar