pygobject-stubs icon indicating copy to clipboard operation
pygobject-stubs copied to clipboard

imprv: generate: Hint callbacks

Open matperc opened this issue 1 year ago • 7 comments

~Blocked by this bug https://github.com/python/mypy/issues/15177~

Closes #144 Closes #149

matperc avatar May 29 '23 14:05 matperc

The bug in mypy is fixed so it should work now.

@lovetox can you test on your code base if everything works fine?

matperc avatar Sep 22 '23 11:09 matperc

~There is a problem on typing with Gio.AsyncReadyCallback it should take var args~

I've fixed this. It works now, I'll leave the draft status since it works only with mypy master.

matperc avatar Sep 22 '23 12:09 matperc

With mypy 1.7 it's working. Before merge please check if it is working as expected in your codebase

matperc avatar Nov 23 '23 08:11 matperc

This generates for me invalid python, if i try it on Gtk3

xoptions=<flags GTK_EXPAND | GTK_FILL of type Gtk.AttachOptions>

also please make a second space between code and FIXME comment

: ... # FIXME Function -> : ... # FIXME Function

This reduces the work the formatter has to do

lovetox avatar Feb 11 '24 07:02 lovetox

oh it seems its not this MR that does this, i have this also on master

I added https://github.com/pygobject/pygobject-stubs/issues/169

lovetox avatar Feb 11 '24 07:02 lovetox

i tested this and didnt run into any problems with the MR.

lovetox avatar Feb 11 '24 15:02 lovetox

also please make a second space between code and FIXME comment

: ... # FIXME Function -> : ... # FIXME Function

This reduces the work the formatter has to do

Is this related to this PR?

matperc avatar Feb 17 '24 10:02 matperc