pygments icon indicating copy to clipboard operation
pygments copied to clipboard

Implement various improvements to the "console" lexer, closes issues #2496-#2498

Open vkoukis opened this issue 2 years ago • 5 comments

ShellSessionBaseLexer: Support heredoc input ShellSessionBaseLexer: Only match prompt once tests: Support arbitrary Lexer options in snippets ShellSessionBaseLexer: Support whitespace in virtualenv prompt

Closes #2496 Closes #2497 Closes #2498

vkoukis avatar Aug 28 '23 11:08 vkoukis

This is a PR to close issues #2496, #2497, #2498. [UPDATED] Looking forward to any feedback you may have, happy to also split this into smaller changes, if you think these modifications need more discussion. [UPDATE: Forced-push so we focus this PR on the lexer changes, will submit HTML formatter change separately]

vkoukis avatar Aug 28 '23 11:08 vkoukis

Yes, please at least separate the HTML formatter change from console lexer changes.

jeanas avatar Aug 28 '23 11:08 jeanas

@jeanas

Yes, please at least separate the HTML formatter change from console lexer changes.

ACK, I have forced push into this branch so we focus this PR on the lexer changes. I will submit the HTML formatter change separately. I have edited my comments above to reflect this.

vkoukis avatar Aug 28 '23 13:08 vkoukis

@vkoukis Do you still plan to pursue this PR?

jeanas avatar Sep 27 '23 18:09 jeanas

@vkoukis Do you still plan to pursue this PR?

@jeanas Yes, for sure. I haven't had enough free time recently to work on it, I would still like to pursue this though.

vkoukis avatar Oct 06 '23 15:10 vkoukis