wgpu-py Improve state of the art for screenshot testing

port of https://github.com/pygfx/pygfx/pull/827

Aug 25 '24 02:08 hmaarrfk

hmm i guess i need to take WPGU_FORCE_OFFSCREEN a little further too.

Aug 25 '24 05:08 hmaarrfk

@hmaarrfk you want me to merge this or does it need some work?

Dec 29 '24 19:12 Korijn

i think this is fine as is right?

I'm not sure if the testing was improved since Aug 24, but i just wanted to keep them in sync. that is finding the "small difference" and the tuning parameters for the tolerance.

Dec 29 '24 19:12 hmaarrfk

hmm i guess i need to take WPGU_FORCE_OFFSCREEN a little further too.

ohhh with this comment...

Dec 29 '24 19:12 hmaarrfk

yeah give me som etime... you know... one day..

Dec 29 '24 19:12 hmaarrfk

I think i remember my concern. there was an other very similar environment variable in this project, and I needed time to figure out the interaction (and I still need time to do so)

Dec 29 '24 20:12 hmaarrfk

Ok at the time, I just had a hard time choosing a variable name.

I think I didn't want to propagate the documentation of 3 variables:

WGPU_ADAPTER_NAME (which doesnt seem to work)
PYGFX_WGPU_ADAPTER_NAME -- pygfx only
WGPUPY_WGPU_ADAPTER_NAME wgpu, so I guess pygfx can use this (this is likely where I got stuck mentally)

Anyway, corrupting an example and running the new instructions in the readme yields:

Dec 30 '24 01:12 hmaarrfk

needless to say, https://github.com/pygfx/wgpu-py/pull/659 needs to be resolved first

Dec 30 '24 01:12 hmaarrfk