pygame-ce
pygame-ce copied to clipboard
SDL3: FRect changes, what to do?
trafficstars
So SDL3 has introduced some FRect changes that break our FRect.clipline tests (ref: https://github.com/libsdl-org/SDL/issues/6791#issuecomment-2241509592)
TL;DR is the changes make FRect operations more mathematically correct (SDL2 FRect would handle top/left edges differently from bottom/right edges) but the changes are inconsistent with regular Rect.clipline which notably hasn't changed since SDL2.
We now have two options:
- Retain SDL2 behaviour.
- Switch to SDL3 behaviour.
Given FRect is pygame-ce specific functionality introduced not too long ago, I think switching to SDL3 way of doing things right away isnt a bad idea. Opening this issue to get more people's opinions on this.