nuitka and libpng

[Starbuck5]

Received a report from a user on discord that png loading in their game crashes when frozen with Nuitka

Windows, Py3.10, pygame-ce 2.5.0, "latest nuitka"

https://discord.com/channels/772505616680878080/822265298085347368/1254516405492256949

Opening this as a placeholder so it doesn't get lost, seems like Andrew has already investigated.

[oddbookworm]

According to the tool nuitka uses to determine binary dependencies, here's what imageext depends on upstream

Here's what imageext depends on for pygame-ce

[oddbookworm]

For now, I've opened a pull request with Nuitka

[Starbuck5]

I believe this issue would also occur with other video and audio formats, beyond just libpng and libjpeg.

[oddbookworm]

I tried with audio and fonts, and they seemed fine

[oddbookworm]

reproducer.zip

Here's the sample project I was working with Build command:

nuitka --standalone main.py --include-data-files=./alien1.png=alien1.png --include-data-files=./alien1.jpg=alien1.jpg --include-data-files=./Roboto-Regular.ttf=Roboto-Regular.ttf --include-data-files=./boom.wav=boom.wav 

[Starbuck5]

SDL_image additional DLLs:

SDL_mixer additional DLLs:

We don't bundle 100% of these (filesize concerns), but we bundle most of them.

Can't we just tell nuitka if it's a DLL and it's in our directory it's important?

[oddbookworm]

I tried a wildcard *.dll, and that didn't work

[Starbuck5]

Also we have to share this "hook" space with pygame?

[oddbookworm]

Yep, because our stuff is in the pygame folder

[oddbookworm]

insert plug for briefcase, which just works

[Starbuck5]

I tried with audio and fonts, and they seemed fine

You tried with a WAV file. It would have the same issue as the original reporter if you tried opus or mp3 or anything else.

insert plug for briefcase, which just works

Let's have all the tools work!

[oddbookworm]

I've updated the pull request to Nuitka to do a wildcard glob of all dlls in the pygame(-ce) install. I don't like doing that, but it seems to be our only option with the way the sdl dynamic linking works. libpng doesn't work without the nuitka fix for us, but does work for upstream because of our custom SDL_image build. Other dlls are broken for both of us, such as libtiff and libjpeg

[Starbuck5]

I feel like nuitka should do a wildcard glob of DLLs by default. What’s wrong with including all the executables?

We’re not ever going to ship out executables in our wheels that aren’t actually used.

[oddbookworm]

I feel like nuitka should do a wildcard glob of DLLs by default. What’s wrong with including all the executables?

We’re not ever going to ship out executables in our wheels that aren’t actually used.

This has already been basically answered in the nuitka pull request, but for future reference: It's basically nuitka trying to save on executable size by not including things that aren't necessary. All of our dlls are necessary, but I wouldn't be surprised if there are quite a few projects out there which include things that aren't really necessary

[oddbookworm]

Going to wait to close this until Nuitka 2.4.8 comes out, which I've been promised will have the pull request incorporated which fixes the issue https://github.com/Nuitka/Nuitka/pull/2947

[Starbuck5]

@oddbookworm I'm assuming the issue is fixed and this can be closed?