pygame-ce icon indicating copy to clipboard operation
pygame-ce copied to clipboard

Published 20 hours ago • verified publisher icon pygame-community

Surface properties

Open ScriptLineStudios opened this issue 1 year ago • 3 comments
trafficstars

Closes #2758

ScriptLineStudios avatar Apr 20 '24 21:04 ScriptLineStudios

Interesting idea!

This PR is adding both .w and .width and .h and .height. Is this actually required? Is it being done for consistency with rect? If we add this we will end up having like atleast 3 ways of doing the exact same thing, which isn't very ideal IMHO

Yeah I also felt it was a little redundant, but yes did it for consistency with Rect.

ScriptLineStudios avatar Apr 21 '24 07:04 ScriptLineStudios

Let's just do width, height, and size for now. (Removing w and h).

I think w and h would be fine to have, but in the interest of making this PR easy to merge let's remove them for now.

They can always be added in the future, but once they're added it's quite hard to remove.

Starbuck5 avatar Apr 21 '24 22:04 Starbuck5

Let's just do width, height, and size for now. (Removing w and h).

I think w and h would be fine to have, but in the interest of making this PR easy to merge let's remove them for now.

They can always be added in the future, but once they're added it's quite hard to remove.

Sounds good!

ScriptLineStudios avatar Apr 24 '24 15:04 ScriptLineStudios