pygame-ce icon indicating copy to clipboard operation
pygame-ce copied to clipboard

Exclude mac specific assets from other builds

Open Starbuck5 opened this issue 1 year ago • 1 comments
trafficstars

This should probably happen after https://github.com/pygame-community/pygame-ce/pull/2557, let that get resolved first.

We have mac specific assets: src_py/pygame_icon_mac.bmp src_py/pygame_icon.icns

Combined, they are 500kb.

~~If we can remove that from the 40 non-mac builds we do, we can reduce the size of a release by 20mb.~~ Edit: forgot about whl compression. They are 286 kb combined compressed, so the 40 builds would save a total 11.4 mb. That's almost as much as getting rid of a full wheel.

On another note, what are pygame_icon.icns and pygame.ico even doing?

Starbuck5 avatar Mar 29 '24 07:03 Starbuck5

I also don't see how pygame.ico and pygame_icon.icns are being used, so we can probably remove them and then test if pygame applications show the icon as they should?

ankith26 avatar Apr 28 '24 07:04 ankith26