pygame-ce icon indicating copy to clipboard operation
pygame-ce copied to clipboard

Requirements dev file

Open oddbookworm opened this issue 1 year ago • 6 comments
trafficstars

Continuation of #2698, using a branch on this repo instead of my own

oddbookworm avatar Jan 29 '24 01:01 oddbookworm

I'm not sure if CI should be using this requirements dev file? It negatively affects build times, and in some builds this has an extreme effect.

I think that's part of the point of having one. If we pin the dep versions, then when something changes that would affect us, the CI would use the new version and would break. Unless we manually pin the versions in the CI too, that wouldn't really fix anything.

oddbookworm avatar Jan 29 '24 21:01 oddbookworm

Why not requirements.txt?

narilee2006 avatar Mar 02 '24 20:03 narilee2006

Requirements-dev is a common way to express development dependencies, I think. These aren't dependencies for pygame-ce's runtime, they are dependencies for building/testing pygame-ce.

Starbuck5 avatar Mar 03 '24 08:03 Starbuck5

Does this need to be updated for/because of https://github.com/pygame-community/pygame-ce/pull/2744 ?

Starbuck5 avatar Mar 10 '24 21:03 Starbuck5

Yup, about to push a commit updating

oddbookworm avatar Mar 12 '24 02:03 oddbookworm

I'll hold off on this until #2824 is resolved, needs updates from meson build too

oddbookworm avatar Apr 27 '24 13:04 oddbookworm

This PR has been superseded by dev.py and therefore I am closing this. But still, thanks for working on it as the work done here still inspired some design and behaviour of the current dev.py.

ankith26 avatar Nov 21 '24 06:11 ankith26