pygae
Features from meuns/galgebra: GA4CS examples, PGA, code-generation, and more
Hi @utensil,
I found a weird thing using pygae/galgebra. Some methods return a Mv instance now but a sympy expression is enough and this crashes Sympy 1.3. Sympy just goes into an infinite recursion using its reflection system and finish by raising an exception.
Regards
Since I have your attention here - would you mind responding to this comment (https://github.com/meuns/galgebra/pull/1#issuecomment-558342817)?
I found a weird thing using pygae/galgebra. Some methods return a Mv instance now but a sympy expression is enough and this crashes Sympy 1.3. Sympy just goes into an infinite recursion using its reflection system and finish by raising an exception.
@meuns Can you make a minimal reproduction of this problem?
I found a weird thing using pygae/galgebra. Some methods return a Mv instance now but a sympy expression is enough and this crashes Sympy 1.3. Sympy just goes into an infinite recursion using its reflection system and finish by raising an exception.
@meuns Can you make a minimal reproduction of this problem?
This is quite easy to reproduce. Just pass any Mv instance to simplify. If I remember well the dot product, the left and right contractions returned some sympy scalar expressions and now they return scalar Mv instances. Not sure this is a problem once the user knows.
If I remember well the dot product, the left and right contractions returned some sympy scalar expressions and now they return scalar Mv instances.
From this description, I can barely recalled that I have done something similar intentionally for consistency. Can't be sure until I get down to try a reprodution.
If I remember well the dot product, the left and right contractions returned some sympy scalar expressions and now they return scalar Mv instances.
This was done in 6cc530c8f323bce17cf6290a42ca1c2fd532591d.
See also #154, which applies this to | too