galgebra icon indicating copy to clipboard operation
galgebra copied to clipboard

Published 20 hours ago • verified publisher icon pygae

Add github actions CI

Open moble opened this issue 1 year ago • 3 comments

This PR attempts to replicate the CircleCI workflow (which is not working as of this writing) in github actions. It also removes references to CircleCI.

It also fixes a few minor things I needed to do to get the tests to pass:

  • Replace the now-deprecated getargspec with getfullargspec in galgebra/lt.py
  • Set self.nargs = 0 in the branch following the getargspec usage, so that it's not referring to a non-existent variable
  • Fix an if statement in galgebra/mv.py so the linter doesn't choke
  • Fix the python_requires syntax in setup.py

This is one half of the split version of #486. The other half is a branch on my fork https://github.com/moble/galgebra/tree/jupyterlite, which starts relative to this PR's first commit; I'll make it into a PR once this is merged.

moble avatar Aug 11 '23 19:08 moble

Okay, I believe I've addressed the comments above.

The tests passed here.

moble avatar Aug 14 '23 18:08 moble

Why is the doc build failed?

Other than this and the need to resolve the conflict, all LGTM.

utensil avatar Aug 15 '23 03:08 utensil

Why is the doc build failed?

Looks like we were one of the lucky few to hit a brownout requiring the new .readthedocs.yaml format. I'll try to update it.

moble avatar Aug 15 '23 14:08 moble

As everything looks good to me, and I wish to polish CI and bump Python etc. Merging this as the foundation. Thanks!

utensil avatar Mar 28 '24 07:03 utensil