galgebra icon indicating copy to clipboard operation
galgebra copied to clipboard

Remove all the deprecated attributes

Open eric-wieser opened this issue 4 years ago • 4 comments

After we do a 0.5.0 release, we should look at removing all of the deprecated properties and methods from the source code, so that 0.6.0 no longer has them.

Grepping for stacklevel= seems to find most (all?) of these. As of writing, there are 26 of these members in the source so far, and removing them would save about 200 lines of code. We should only apply this to deprecations which existed by the time of the 0.5.0 release.

eric-wieser avatar May 04 '20 12:05 eric-wieser

Should we continue to finish #196 in 0.6.0 and do this in the next release? So we can tell the user to try 0.6.0 first to see what should be used instead and then move to newer versions without a clue.

utensil avatar Jun 02 '20 12:06 utensil

My original plan was:

  • In 0.6.0, remove the things we already deprecated in 0.5.0
  • In 0.6.0, deprecate any more that are easy to get rid of
  • In 0.7.0, deprecate the ones from the point above.

However, another option would be:

  • In 0.6.0, deprecate any more that are easy to get rid of
  • In 1.0.0, remove all of them.

eric-wieser avatar Jun 02 '20 12:06 eric-wieser

Yeah I prefer the latter as the deprecated methods are actually no longer in our ways and it would provide a smoother migration process by this middle point ("So we can tell the user to try 0.6.0 first to see what should be used instead and then move to newer versions without a clue.").

utensil avatar Jun 03 '20 02:06 utensil

I still imagine that there is quite some code written in the past since I've read quite some papers claiming the author used GAlgebra to verify some identities, although I haven't seen them coming and the code is likely not open source, they might still need to migrate to the new version one day.

utensil avatar Jun 03 '20 02:06 utensil