galgebra icon indicating copy to clipboard operation
galgebra copied to clipboard

Fix incorrect description of Hestenes inner product in examples

Open utensil opened this issue 5 years ago • 4 comments

In https://nbviewer.jupyter.org/github/pygae/galgebra/blob/master/examples/ipython/inner_product.ipynb :

image

It's inconsistent with implementation and the original literature:

image

This should be corrected. And it's better to add some description of all three definitions:

image

from Geometric Algebra with Applications in Science and Engineering .

utensil avatar Dec 06 '19 15:12 utensil

It's inconsistent with implementation and the original literature

How so? Looks identical to the implementation and literature to me, if you start with the assumption that r and s are non-negative

eric-wieser avatar Dec 06 '19 15:12 eric-wieser

image

This is particularly wrong (my own mistake). And the formula fails to mention how it should be like for arbitrary multivectors (i.e. the summing).

utensil avatar Dec 06 '19 15:12 utensil

Apart from the out of place "of", that sentence is true, isn't it?

And the formula fails to mention how it should be like for arbitrary multivectors

That's fair.

It might be worth adding the mathematical description to the docstring of hestenes_dot

eric-wieser avatar Dec 06 '19 15:12 eric-wieser

Apart from the out of place "of", that sentence is true, isn't it?

No. It intended to describe how it works, not a consequence of how it works.

utensil avatar Dec 11 '19 08:12 utensil