clifford icon indicating copy to clipboard operation
clifford copied to clipboard

Add 2D PGA (Cl(2,0,1))

Open kliment opened this issue 3 years ago • 7 comments

Adds a 2D version of the projective GA using Cl(2,0,1) - this is wonderful for working with lines, points, areas, angles and distances in the plane.

kliment avatar Oct 04 '20 21:10 kliment

This pull request introduces 1 alert when merging 7b163aea7ed7af4d7ddf12a5af02136383d8628f into a1b1ba3519612af4d0e0c842ff290ee0f5d25ca1 - view on LGTM.com

new alerts:

  • 1 for Modification of dictionary returned by locals()

lgtm-com[bot] avatar Oct 04 '20 21:10 lgtm-com[bot]

Could you add an entry to https://github.com/pygae/clifford/blob/master/docs/predefined-algebras.rst too?

eric-wieser avatar Oct 04 '20 21:10 eric-wieser

Done

kliment avatar Oct 05 '20 06:10 kliment

This pull request introduces 1 alert when merging e526291fb8220c6a5740cd5deb4ec17badef5153 into a1b1ba3519612af4d0e0c842ff290ee0f5d25ca1 - view on LGTM.com

new alerts:

  • 1 for Modification of dictionary returned by locals()

lgtm-com[bot] avatar Oct 05 '20 06:10 lgtm-com[bot]

Just checking, do you need anything more from my end to merge this?

kliment avatar Feb 17 '21 12:02 kliment

@eric-wieser what do you think? not sure about the tests, but seems like a pretty simple addition?

arsenovic avatar Feb 23 '21 13:02 arsenovic

There was a discussion on our slack about what to name the algebra, we should check if that came to a conclusion before merging.

eric-wieser avatar Feb 23 '21 13:02 eric-wieser