pytorch_geometric icon indicating copy to clipboard operation
pytorch_geometric copied to clipboard

Add `class-resolver` for `Aggregation`

Open cthoyt opened this issue 3 years ago • 3 comments

As a follow-up to #4687, this pull request adds a class-resolver for aggregations in torch_geometric.nn.aggr. It also adds a class docstring with an example on how to use it.

Note that class_resolver is a pure python package with no dependencies.

cthoyt avatar May 25 '22 22:05 cthoyt

Codecov Report

Merging #4716 (1cb1f74) into master (cb92831) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4716   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files         321      321           
  Lines       17207    17209    +2     
=======================================
+ Hits        14179    14181    +2     
  Misses       3028     3028           
Impacted Files Coverage Δ
torch_geometric/nn/aggr/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cb92831...1cb1f74. Read the comment docs.

codecov[bot] avatar May 25 '22 23:05 codecov[bot]

schönes Feierabend btw

cthoyt avatar May 25 '22 23:05 cthoyt

@cthoyt We added basic support for aggregation_resolver in https://github.com/pyg-team/pytorch_geometric/pull/4749. Let me know once class-resolver is available on conda and I am happy to make the switch.

rusty1s avatar Jun 07 '22 11:06 rusty1s