pytorch_geometric icon indicating copy to clipboard operation
pytorch_geometric copied to clipboard

make `coalesce` compile friendly

Open ValterH opened this issue 1 month ago • 2 comments

Update coalesce to be torch compiled without graph breaks.

ValterH avatar Nov 06 '25 11:11 ValterH

@akihironitta I added a test case, but had to remove the error message as torch._check requires the message to be callable and passing a lambda function causes a graph break during compilation.

ValterH avatar Nov 06 '25 16:11 ValterH

Codecov Report

:x: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 85.08%. Comparing base (c211214) to head (1bfbbf2). :warning: Report is 137 commits behind head on master.

Files with missing lines Patch % Lines
torch_geometric/utils/_coalesce.py 66.66% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10522      +/-   ##
==========================================
- Coverage   86.11%   85.08%   -1.03%     
==========================================
  Files         496      510      +14     
  Lines       33655    35967    +2312     
==========================================
+ Hits        28981    30603    +1622     
- Misses       4674     5364     +690     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Nov 06 '25 20:11 codecov[bot]