pyfar icon indicating copy to clipboard operation
pyfar copied to clipboard

Inconsistency for fractional filter returns

Open ahms5 opened this issue 1 year ago • 1 comments

fractional_octave_bands and reconstructing_fractional_octave_bands have different output parameter

seems like reconstructing_fractional_octave_bandsreturns signal, frequencies or filter, frequencies and fractional_octave_bands returns signal or filter

also the inputs are not perfect. the sampling_rate is not at the same position and num_fractions has sometimes defaults and another time not.

pyfar.dsp.filter.reconstructing_fractional_octave_bands(signal, num_fractions=1, frequency_range=(63, 16000), overlap=1, slope=0, n_samples=4096, sampling_rate=None)

pyfar.dsp.filter.fractional_octave_bands(signal, num_fractions, sampling_rate=None, frequency_range=(20.0, 20000.0), order=14)

ahms5 avatar Jul 26 '24 10:07 ahms5

We suggest to harmonize the return parameters, either removing the return of center frequencies in the reconstructing filter bank or add to the iso IIR filterbank. Decision pending at the next weekly meeting @f-brinkmann ;)

mberz avatar Jul 26 '24 11:07 mberz