Pyfa icon indicating copy to clipboard operation
Pyfa copied to clipboard

Dependency update: Windows release tracking issue

Open DarkFenX opened this issue 1 year ago • 18 comments

This issue is for tracking major issues which appeared with release of https://github.com/pyfa-org/Pyfa/releases/tag/v2.57.3

Report inability to launch pyfa, crashes, weird looking UI here.

Changes relatively latest release: just dependencies were updated, but it also included update of pyinstaller, which historically has a significant chance to cause windows-related issues (especially when it comes to anti-virus monitors)

DarkFenX avatar Dec 04 '23 10:12 DarkFenX

Bitdefender gives a message of: "disinfection is in progress". The file C:\Program Files\pyfa\is-H5KQB.tmp has been detected as infected with Gen:Variant.Tedy.488325 and Bitdefender could not clean this item. A device restart is required to finalize the cleaning process.

Rguz126 avatar Dec 05 '23 19:12 Rguz126

This seems to be a false positive, see #2550 (and let's keep discussion related to false positive detection there).

Please report this as false positive to bitdefender: https://www.bitdefender.com/consumer/support/answer/29358/

Once they whitelist pyinstaller 6.2, the issue will go away. I'd report it myself, but they need a screenshot of the issue.

DarkFenX avatar Dec 05 '23 19:12 DarkFenX

Cannot launch pyfa, error message says:

pyfa v2.57.1 EVE Data Version: 2443636 (2023-12-05 19:37:07)

OS version: Windows-10-10.0.19045-SP0 Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)] wxPython version: 4.2.1 (wxWidgets 3.2.2.1) SQLAlchemy version: 1.4.50 Logbook version: 1.7.0.post0 Requests version: 2.31.0 Dateutil version: 2.8.2

####################

Traceback (most recent call last): File "gui\chrome_tabs.py", line 338, in OnSize File "gui\chrome_tabs.py", line 800, in UpdateSize File "gui\chrome_tabs.py", line 1367, in AdjustTabsSize File "gui\chrome_tabs.py", line 423, in SetSize File "gui\chrome_tabs.py", line 482, in InitTab File "gui\chrome_tabs.py", line 528, in ComposeTabBack TypeError: Image.Scale(): argument 1 has unexpected type 'float'

liligeng111 avatar Dec 06 '23 14:12 liligeng111

Fixed in 3593d16bd1b8b00e2f6c799fa6d3272d50ed62b2

DarkFenX avatar Dec 06 '23 15:12 DarkFenX

@liligeng111 please try this build: https://ci.appveyor.com/project/pyfa-org/pyfa/builds/48694338/job/2hhrq3g5st87u78n/artifacts

If there are any more crashes, lmk. If not, I will make another release shortly.

DarkFenX avatar Dec 06 '23 15:12 DarkFenX

Thank you for the very quick fix. pyfa launches now, but another error message pops. I will be able to help with more testing tomorrow.(heading to bed now)

pyfa v2.57.1+1-g3593d16bd EVE Data Version: 2443636 (2023-12-05 19:37:07)

OS version: Windows-10-10.0.19045-SP0 Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)] wxPython version: 4.2.1 (wxWidgets 3.2.2.1) SQLAlchemy version: 1.4.50 Logbook version: 1.7.0.post0 Requests version: 2.31.0 Dateutil version: 2.8.2

####################

Traceback (most recent call last): File "gui\chrome_tabs.py", line 1216, in OnPaint TypeError: DC.SetDeviceOrigin(): argument 1 has unexpected type 'float'

liligeng111 avatar Dec 06 '23 16:12 liligeng111

There are gonna be a bunch of those errors. I fixed lots of them which appeared on my laptop, but seems some of them flew under radar for some unknown reason (maybe people who have them use non-integer interface scaling? No idea).

New error fixed in b7a5b33ff6c7e876c08602fb39b8de9f8ad73133. Build is progress.

DarkFenX avatar Dec 06 '23 16:12 DarkFenX

@liligeng111 try this build: https://ci.appveyor.com/project/pyfa-org/pyfa/builds/48695277/job/wd9e2cyt15ijj1m5/artifacts

DarkFenX avatar Dec 06 '23 17:12 DarkFenX

I just tested, no more error messages. Thank you!

liligeng111 avatar Dec 07 '23 02:12 liligeng111

@liligeng111 can you open various windows (graphs, all editors, browsing ESI fits, ESI characters, attribute overrides) as well? Just opening should be enough. And let me know if it's okay or there are any crashes.

DarkFenX avatar Dec 07 '23 02:12 DarkFenX

I just tested, and all windows work fine. However, export all fittings to HTML gives the following error message: pyfa v2.57.1+2-gb7a5b33ff EVE Data Version: 2443636 (2023-12-05 19:37:07)

OS version: Windows-10-10.0.19045-SP0 Python version: 3.11.6 (tags/v3.11.6:8b6ee5b, Oct 2 2023, 14:57:12) [MSC v.1935 64 bit (AMD64)] wxPython version: 4.2.1 (wxWidgets 3.2.2.1) SQLAlchemy version: 1.4.50 Logbook version: 1.7.0.post0 Requests version: 2.31.0 Dateutil version: 2.8.2

####################

Traceback (most recent call last): File "gui\mainFrame.py", line 914, in exportHtml wx._core.wxAssertionError: C++ assertion ""IsRunning()"" failed at ....\src\common\evtloopcmn.cpp(92) in wxEventLoopBase::Exit(): Use ScheduleExit() on not running loop

liligeng111 avatar Dec 07 '23 04:12 liligeng111

No idea how to fix that one, not enough data from the error. But I found a bug which is applicable to all platforms and which broke html export, which is fixed now.

DarkFenX avatar Dec 07 '23 12:12 DarkFenX

https://github.com/pyfa-org/Pyfa/releases/tag/v2.57.2

DarkFenX avatar Dec 07 '23 14:12 DarkFenX

Everything is working now, thank you very much!

liligeng111 avatar Dec 07 '23 14:12 liligeng111

Regarding issue you posted earlier, there is an issue on that apparently, created by me a while ago: https://github.com/wxWidgets/Phoenix/issues/1610

DarkFenX avatar Dec 07 '23 20:12 DarkFenX

@DarkFenX 2.57.2 be deleted by the windows defender,said there is a virous.

chenjie199234 avatar Dec 08 '23 08:12 chenjie199234

https://i.imgur.com/1MQ7zzT.png

Same here

SebFerraro avatar Dec 08 '23 13:12 SebFerraro

Decremented pyinstaller version once again, v2.57.3 should work for windows defender

DarkFenX avatar Dec 08 '23 17:12 DarkFenX