Pyfa icon indicating copy to clipboard operation
Pyfa copied to clipboard

Python 3.10 compatibility

Open wereii opened this issue 3 years ago • 5 comments

This fixes problems with wxPython and python310 where C extensions will not silently accept floats as ints in function arguments anymore.

Also see #2391

wereii avatar Feb 13 '22 17:02 wereii

This is still a big WIP. This PR is there just for tracking.

wereii avatar Feb 13 '22 17:02 wereii

well, things have come a good way it seems, on the dep_facelift branch using a patched logbook it seems to be working with python 3.10 now.

Phoenix591 avatar Jul 16 '22 05:07 Phoenix591

@Phoenix591 so the plan is to eventually merge the dep_facelift changes into master, right? I am thinking about switching pyfa on AUR to this branch.

wereii avatar Jul 21 '22 12:07 wereii

@Phoenix591 so the plan is to eventually merge the dep_facelift changes into master, right? I am thinking about switching pyfa on AUR to this branch.

Presumably at some point, but I'm just someone who decided to try it

Phoenix591 avatar Aug 15 '22 13:08 Phoenix591

The plan is to have it merged as soon as it's ready.

FYI, even on this branch, some windows still have issues - for example, implant set editor. And i think this issue has to be fixed somewhere on wx side, because all sizes pyfa passes are integer, issue happening there is somewhere deeper down.

DarkFenX avatar Aug 28 '22 23:08 DarkFenX

Closing this, as dep_facelift branch has had all the needed changes and will be merged to master soon

DarkFenX avatar Dec 05 '23 09:12 DarkFenX