Pyfa icon indicating copy to clipboard operation
Pyfa copied to clipboard

Possible improvement for method 'smartSort'

Open OshinoMoumou opened this issue 4 years ago • 0 comments

Greetings! I noticed that method smartSort referred a StackOverflow post, while a recent comment to it noticed that it doesn't work for sorting sets of version numbers alphanumerically; e.g., v1.0.1, v3.5.3, v3.2.4. I'm trying to learn the usefulness of such small updates on StackOverflow. Would this comment help improve your code? I understand that might not happen in real life situation. In that case, do you think this comment can help prevent future defect (if the code were reused somwhere else)? I'll really appreciate it if you could kindly give me some feedback or suggestions. Thank you very much for your time. Have a nice day!

OshinoMoumou avatar May 30 '21 07:05 OshinoMoumou