pyfa-org
Ship fit "Diff" function - Automated compare of different fits for the same ship.
This is a feature request for an automated comparison of two fits for the same ship that highlight the differences between then - pointing out common modules, modules in "A" and not in "B" and those in "B" and not in "A". Maybe even one that spits out a multibuy list of what's needed to turn "A" into "B"
Thanks!
Here, for reference was a short slack discussion:
o/ What's the best place to drop a request for a feature/function for pyfa? Here? or https://github.com/pyfa-org/Pyfa/issues/new ? or ???
GitHub
Build software better, together
GitHub is where people build software. More than 20 million people use GitHub to discover, fork, and contribute to over 55 million projects.
ebag333 [12:59 PM]
@dallidiem.igraine if you want to discuss it, then here. If you want to get it documented and more likely to be looked at, than Github issues.
dallidiem.igraine [12:59 PM]
Thanks, a question here to make sure I'm not missing how to do it - then Ill more it to Gib hub if its indeed new.
[1:01]
What I'd like to do is compare, side by side, two fits I have in pyfa for the same ship - but the modules in each rack are in a different order making that compare difficult. Is there a way to either automatlically sort them (alphabetically?) so I can visually compare, or is there an automated fit "diff" function I missed?
ebag333 [1:02 PM]
there is NOT a diff.... but....
[1:02]
I just had an idea.
[1:02]
it's nothing new, a million people have requested it
dallidiem.igraine [1:03 PM]
That's why I was asking - i figured I couldn't be the first to need/want something like this..
ebag333 [1:03 PM]
previously we didn't have a way of doing it. But I have a branch that it'd be trivial in
[1:03]
thanks to some fit caching. :smile:
dallidiem.igraine [1:04 PM]
Cool. Do you need me to post something in github then so you can track it? Or is there one of the million requests already there :slightly_smiling_face:
ebag333 [1:05 PM]
you know, I don't believe that we have an open issue on it. or at least I can't find one
[1:05]
please open one
I have a branch we can do this in! @blitzmann will hate the solution.... 😁
It would be nice if you would elaborate and discuss your design and functional intentions instead of doing a bunch of work in secret that may be declined. Just saying.
As to the topic at hand, it's true, similar things have been requested before (not really comparing modules, but comparing stats). We haven't really had a good way to do comparisons due to our tabbed interface. There have been thoughts throughout the years to maybe build out a comparison window that would compare stats (or maybe modules in this case) between two fits. No one has really come forward with an interesting solution that would work, graphically anyway.
@Dallidiem Are you just looking for a way to compare the items that are attached to a fit, or the stats as well? Those are two very different sets of requirements. The former would be trivial - could create a window that listed out the modules of two fits side by side, use set operations to determine what one fit had that the other didn't, and then change the background color of the modules. Would we want to include boosters / implants / projections / etc? Lots of design requirements that are just left out in the open.
Stat comparisons could be done in a similar way, but it would take a lot more time and need to be really thought through on how to display that information.
It would be nice if you would elaborate and discuss your design and functional intentions instead of doing a bunch of work in secret that may be declined.
Bulk of the base work is already done and hardly in secret, I've been spamming the feed on it the last two days. ;)
I wasn't looking for stat comparisons, that seems simple enough by having two tabs open in the tool already and clicking back and forth. My desire is to easily see which modules are different from one fitting to another - maybe even somehow flagging differences in variants being less of a change than differences in module. As bonus, it would be great to spit out a report of what modules are needed to convert "Fit A" into "Fit B" - reusing the overlap. For my needs, differences in implants, etc aren't critical. Its the basic ship compare.
