pyexcel-xlsx icon indicating copy to clipboard operation
pyexcel-xlsx copied to clipboard
verified publisher icon pyexcel

Allow for set and other unsubscriptable data structures.

Open craiga opened this issue 2 years ago • 6 comments

An attempt to fix https://github.com/pyexcel/pyexcel-xlsx/issues/52

With your PR, here is a check list:

  • [x] Has test cases written?
  • [x] Has all code lines tested?
  • [x] Has make format been run?
  • [x] Please update CHANGELOG.yml(not CHANGELOG.rst)
  • [x] Has fair amount of documentation if your change is complex
  • [x] Agree on NEW BSD License for your contribution

craiga avatar Feb 23 '23 18:02 craiga

Some tests are still failing here on my machine and I'm not sure whether this is due to my environment, whether my change has has an unintended consequence, or whether an update to some other library is causing an issue in the tests.

Is there CI or anything similar this can be run through to get a clear view on this?

craiga avatar May 01 '23 17:05 craiga

can you someone try to merge this fix?

kodurusivakumar34 avatar Jul 03 '23 07:07 kodurusivakumar34

@craiga can you please try to merge this pull request

kodurusivakumar34 avatar Jul 14 '23 05:07 kodurusivakumar34

@kodurusivakumar34 I don't have write permissions here, that'd be a job for @chfw I believe.

craiga avatar Jul 14 '23 10:07 craiga

@chfw can you please review and merge this PR

kodurusivakumar34 avatar Jul 14 '23 10:07 kodurusivakumar34

What's the status on this merge?

Mokatsu avatar Sep 21 '23 00:09 Mokatsu