pyenv-virtualenv icon indicating copy to clipboard operation
pyenv-virtualenv copied to clipboard

Why is prompt changing being removed?

Open tadeoos opened this issue 6 years ago • 3 comments

Hey,

according to current output:

pyenv-virtualenv: prompt changing will be removed from future release. configure `export PYENV_VIRTUALENV_DISABLE_PROMPT=1' to simulate the behavior.

Can I ask how you came to this decision? I really like this feature

tadeoos avatar Jun 19 '18 22:06 tadeoos

You might want to take a look here: https://github.com/pyenv/pyenv-virtualenv/issues/135

PaulRBerg avatar Aug 06 '18 19:08 PaulRBerg

Had the same question. Went with https://github.com/pyenv/pyenv-virtualenv/issues/135#issuecomment-582180662 as my workaround.

pllim avatar Jul 02 '20 19:07 pllim

@yyuu , since it was you who added the warning, could you comment?

My guess is that it's because Virtualenv themselves were going to do that. ...and IIRC already did it, so maybe we can proceed with the removal?

Would be nice to learn their rationale, too, of course...

native-api avatar Nov 25 '21 09:11 native-api

Looking at https://github.com/pypa/virtualenv/blob/main/src/virtualenv/activation/bash/activate.sh , there's no deprecation, not to mention, removal of the prompt changing in sight.

Lacking any response from @yyuu, my guess is:

Pyenv-virtualenv makes virtualenvs behave like regular installations. The prompt changing removal was intended to erase the difference even further.

native-api avatar Jan 31 '23 19:01 native-api

Pyenv-virtualenv makes virtualenvs behave like regular installations. The prompt changing removal was intended to erase the difference even further.

In which case, we can as well go the other way and add printing of the active installation(s) to the prompt in the base Pyenv.

native-api avatar Jan 31 '23 19:01 native-api