pydio-core
pydio-core copied to clipboard
Are you still there message has very odd units

https://github.com/pydio/pydio-core/blob/cf13dcd5ad93bb1e8a59c020951c1a5d219c6f11/core/src/plugins/gui.ajax/res/js/ui/ReactUI/modal/ActivityWarningDialog.js#L57
https://github.com/pydio/pydio-core/blob/64bd811df8b7552a61357df657c206ce4cf5bef5/core/src/plugins/core.ajaxplorer/i18n/en.php#L433 "375t" => "Are you still there?", https://github.com/pydio/pydio-core/blob/64bd811df8b7552a61357df657c206ce4cf5bef5/core/src/plugins/core.ajaxplorer/i18n/en.php#L434
https://github.com/pydio/pydio-core/blob/b6dc3e02fd132e0cb0cbcd41f576a006cc5a9b6a/core/src/plugins/gui.ajax/res/js/core/util/ActivityMonitor.es6#L267
This is pretty bad in a number of ways:
__LOGOUT__:- "mn" is a totally bogus abbreviation for minutes.
- This isn't localized/localizable.
__IDLE__:- There's no unit for this at all.
- The
entext is corrupt:since more thanis broken, it could befor more than X {delta-units}orsince {absolute-time}.- There should be a period for both sentence-like parts of this message:
We ... than __IDLE__. For ... in __LOGOUT__.