pydata
Adding `open_datatree` backend-specific keyword arguments
- [x] Closes ##9135
- [ ] User visible changes (including notable bug fixes) are documented in
whats-new.rst - [ ] New functions/methods are listed in
api.rst
you might want to rebase / cherry-pick the two commits for this PR onto main, so there's only those two commits to check in this PR. If you don't have any idea how to do that, I can do it for you.
so unfortunately I can't push to your repository, because it is a fork of someone else's fork (and I'm not a maintainer on that fork). To fix that, you can either request someone from github to "reroute" your fork, or you can pull all your branches to local (I'm sure you did already), delete the repository and fork again. I'm not sure what would happen to this PR, though.
if you want to fix up this PR (which is usually much quicker), you can also follow the steps yourself. Basically, what you do is:
git switch main
git pull
git switch open-dtree-kwargs
# rewind to main
git reset --hard HEAD~60
git merge main
# apply the two commits that were added in this PR
git cherry-pick 179b6960c6e2f49b38eda13a97d977a72bcb5990
git cherry-pick 563b5dbda4dabd253c38c9ca577015224447314f
git push --force
Do we need tests for this?
Funny you should ask - it turns out this functionality wasn't tested to begin with, so @eni-awowale and I are actually working on implementing some (started at SciPy sprints and not yet opened as a draft PR, but located here). Thanks to @santisoler for his help getting that effort started during Sprints!
@JessicaS11 it would be great if you could push whatever you have as a PR (don't worry about perfecting it!) just so that those tests don't get lost in the ether
