xarray icon indicating copy to clipboard operation
xarray copied to clipboard

Datatree design discussions - weekly meeting

Open TomNicholas opened this issue 1 year ago • 10 comments

What is your issue?

In the bi-weekly dev meeting today we agreed that deliberate higher-level discussions of datatree's design would be useful. (i.e. we're not worried about our ability to write high-quality code, so let's focus review time more explicitly on the high-level design questions.)

This could take the form of me just talking through what I did in a certain part of the code and why, or a targeted discussion on specific design questions that I was never quite sure about. Some examples of the latter, as food for thought:

  • [ ] Inheritance of dimension coordinates from parent nodes? https://github.com/xarray-contrib/datatree/issues/297
  • [x] ~~Symbolic links? https://github.com/xarray-contrib/datatree/issues/5~~ (we decided this was overkill)
  • [ ] Is dt.ds ugly? See also the difference between dt.ds and dt.to_dataset() https://github.com/xarray-contrib/datatree/issues/303#issuecomment-1917798769
  • [ ] Which methods should map over the subtree and which shouldn't? (can't find the issue for this one)
  • [ ] Ignore missing dims when mapping over subtree? https://github.com/xarray-contrib/datatree/issues/67
  • [ ] API for sub-tree selection https://github.com/xarray-contrib/datatree/issues/254
  • [ ] API for merging leaves https://github.com/xarray-contrib/datatree/issues/192
  • [ ] Dict-like interface ambiguities https://github.com/xarray-contrib/datatree/issues/240
  • [ ] The tree broadcasting rabbit hole https://github.com/xarray-contrib/datatree/issues/199
  • [ ] Relationship between datatree and catalogs https://github.com/xarray-contrib/datatree/issues/134
  • [ ] Should xr.concat/xr.merge accept DataTree objects? (and map over them by default?) https://github.com/pydata/xarray/issues/9106

There was also this design doc I wrote at one point

@flamingbear are you free at 11:30am EST on Tuesday each week? @shoyer, @keewis and I are all free then. Others also welcome (e.g. @owenlittlejohns , @eni-awowale, @etienneschalk), but not required :)

TomNicholas avatar Feb 14 '24 18:02 TomNicholas

@TomNicholas Yes, I'm good on 11:30am EST Every Tuesday.

flamingbear avatar Feb 14 '24 18:02 flamingbear

Thanks for putting this together @TomNicholas! 11:30 EST on Tuesdays should generally work for me.

eni-awowale avatar Feb 14 '24 19:02 eni-awowale

Great. 11:30am-12:00am EST every week it is then! (We can overrun if necessary, but prioritize agenda items so as to respect people's time who can't stay for longer.)

Google calendar event link (There is an xarray calendar but I don't think I have access to it)

We'll use the same zoom link as for the bi-weekly dev call.

Meeting notes

TomNicholas avatar Feb 14 '24 19:02 TomNicholas

Google calendar event link (There is an xarray calendar but I don't think I have access to it)

FYI I can't open this calendar link.

flamingbear avatar Feb 14 '24 20:02 flamingbear

FYI I can't open this calendar link.

Ugh - I tried changing the account which owns the event, but if that still doesn't work then just forget about it. I'll post here if we need to cancel or change the time or anything.

TomNicholas avatar Feb 16 '24 02:02 TomNicholas

Following up from our discussion today (@shoyer @owenlittlejohns @keewis @flamingbear) the original issue about storing xr.Variable objects rather than xr.Dataset objects is here: https://github.com/xarray-contrib/datatree/issues/2#issuecomment-924217495. My actual reasoning is recorded in this comment https://github.com/xarray-contrib/datatree/issues/2#issuecomment-924233090, but this is not set in stone!

TomNicholas avatar Feb 20 '24 20:02 TomNicholas

I can't make the normal time of 11:30am EST tomorrow (it clashes with a job talk I need to attend).

The only other time tomorrow I could do is 1 hour earlier (10:30am EST). I'll be on zoom then anyway in case anyone shows up!

@shoyer @flamingbear @eni-awowale @owenlittlejohns

TomNicholas avatar Mar 19 '24 05:03 TomNicholas

I'd like to pop in and be a fly on the wall of these meetings if they're still happening... lmk

schlich avatar Apr 03 '24 12:04 schlich

@schlich yes they are still happening! You missed one yesterday in fact. You're welcome to pop in.

TomNicholas avatar Apr 03 '24 14:04 TomNicholas

Wonderful, it's in my calendar

schlich avatar Apr 03 '24 14:04 schlich