xarray icon indicating copy to clipboard operation
xarray copied to clipboard

Published 20 hours ago • verified publisher icon pydata

Added support for the new compression argument in netCDF4 > 1.6.0

Open markelg opened this issue 3 years ago • 3 comments

  • [x] Closes #6929
  • [x] Tests added
  • [ ] User visible changes (including notable bug fixes) are documented in whats-new.rst

markelg avatar Sep 02 '22 09:09 markelg

I think this is ready, unfortunately it does not make sense to merge it yet, and one test is failing, because netcdf-c 4.9.0 is not yet available in conda-forge (see https://github.com/conda-forge/libnetcdf-feedstock/pull/140). So I would put it on hold.

markelg avatar Sep 08 '22 08:09 markelg

I think this is ready, unfortunately it does not make sense to merge it yet, and one test is failing, because netcdf-c 4.9.0 is not yet available in conda-forge (see https://github.com/conda-forge/libnetcdf-feedstock/pull/140). So I would put it on hold.

Should exist now.

headtr1ck avatar Oct 06 '22 19:10 headtr1ck

We elected not to start rebuilding things with netCDF 4.9.0 since 4.9.1 should be out realSoonNow™️ , so I don't think there's a netcdf4 package in conda-forge that has it yet.

dopplershift avatar Oct 06 '22 19:10 dopplershift

Thanks @markelg!

dcherian avatar Dec 01 '22 22:12 dcherian

Sorry for the delay, I completed all the remaining tasks. I hope is ready now. There are some error in the tests but look unrelated to this. There seems to be an assert equal failing because of a nan and nan !=nan.

markelg avatar Oct 30 '23 16:10 markelg