xarray icon indicating copy to clipboard operation
xarray copied to clipboard

Add allow_failures flag to Dataset.curve_fit

Open StanczakDominik opened this issue 3 years ago • 2 comments

  • [x] Closes #6317
  • [ ] Tests added
  • [x] User visible changes (including notable bug fixes) are documented in whats-new.rst

For some reason, my grepping doesn't seem to show any existing tests for curve_fit...?

StanczakDominik avatar Apr 26 '22 13:04 StanczakDominik

Thanks @StanczakDominik can you add a test for this behaviour? The existing tests are here: https://github.com/pydata/xarray/blob/f2d0eb49b06f216117f048287e0796c1b6fd0a1d/xarray/tests/test_dataarray.py#L4079

dcherian avatar Apr 26 '22 19:04 dcherian

Gah, I kept grepping for curve_fit with the underscore! 😅 Thanks for the pointer!

StanczakDominik avatar Apr 27 '22 05:04 StanczakDominik

@StanczakDominik are you still motivated to work on these tests?

headtr1ck avatar Mar 26 '23 19:03 headtr1ck

Hi! I would also like to see this implemented, so I rebased this branch and added a test in #7891.

mgunyho avatar Jun 04 '23 09:06 mgunyho